From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Rewrite eventfd01 using new LTP API
Date: Fri, 21 Jul 2023 14:50:12 +0200 [thread overview]
Message-ID: <20230721125012.GA1421542@pevik> (raw)
In-Reply-To: <20230329055459.GA833475@pevik>
Hi Andrea,
> Hi Andrea,
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > + TST_EXP_FD(eventfd(EVENT_COUNT, EFD_NONBLOCK));
> > + fd = TST_RET;
> NOTE: we could merge the testsuite now, but if you send soon the patch for
> macros returning TST_RET (you discussed with Cyril at v2), all tests could be
> adapted before merge.
Once you have time, could you please send v4, which uses code proposed by Cyril?
fd = TST_EXP_FD(eventfd(0, EFD_NONBLOCK));
Or, Cyril, if you post your RBT, I can change this before merge. Because the
proposed include/tst_test_macros.h change was merged in 303eb96a3
("tst_test_macros.h: Support return value in TST_* macros") we should finish
this nice work.
Kind regards,
Petr
> Kind regards,
> Petr
[1] https://lore.kernel.org/ltp/ZBwgtsRUnkhzZFxZ@yuki/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-21 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 9:25 [LTP] [PATCH v3] Rewrite eventfd01 using new LTP API Andrea Cervesato
2023-03-29 5:54 ` Petr Vorel
2023-07-21 12:50 ` Petr Vorel [this message]
2023-07-21 14:51 ` Cyril Hrubis
2023-07-21 15:09 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721125012.GA1421542@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox