From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CA9AC001DF for ; Tue, 25 Jul 2023 12:23:42 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 902403CB64B for ; Tue, 25 Jul 2023 14:23:40 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 49D153C8B7A for ; Tue, 25 Jul 2023 14:23:28 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 07F5C1A00CC9 for ; Tue, 25 Jul 2023 14:23:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E088A1F88B; Tue, 25 Jul 2023 12:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1690287806; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NPecIgTJjYFWOOT92tEnz9TFjReiJ9aUJqQt7n6w83Q=; b=Wnx0O40Ax5RpqOf11xWBIyhTHGZ9mqSjV6GXJKJkqwGR0WKE1I6WdRDKLhR6LZJaSd5xaM nJYIHjx5MYoS8OkAy6j3vSQTPEdP93BaMVEWhV2KKpNJHS+s11Zahs4yLe+AKyANZxG5Zg MzODfDW4P51BG60r33Wmja28WymuEjk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1690287806; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NPecIgTJjYFWOOT92tEnz9TFjReiJ9aUJqQt7n6w83Q=; b=A/PPRcAsCfwJpXaJp2Q+LoIqS8Hf8JHLWVIstTaHRkxGCvRtskvUZcb8HcgvkYufxLmdgP zV5Qdt8ZgRb642CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6DBC13342; Tue, 25 Jul 2023 12:23:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ADaxJr6+v2Q6PQAAMHmgww (envelope-from ); Tue, 25 Jul 2023 12:23:26 +0000 Date: Tue, 25 Jul 2023 14:23:25 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: <20230725122325.GB12613@pevik> References: <20230719110051.1237775-1-pvorel@suse.cz> <20230719110051.1237775-3-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 1.0.1 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 2/4] lib/C-API: Add option -V to print LTP version X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Martin Doucha , ltp@lists.linux.it, Richard Palethorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Cyril, > Hi! > > It can be useful for troubleshooting reported issues. > I still wonder if this should be rather put into the output of the -h or > both. I used -V, because this is common, but I have no problem to add it to -h or even move to -h (i.e. not introduce -V). Any more opinions, please? Kind regards, Petr > > Signed-off-by: Petr Vorel > > --- > > lib/tst_test.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > diff --git a/lib/tst_test.c b/lib/tst_test.c > > index 04da456c6..456d3d1e6 100644 > > --- a/lib/tst_test.c > > +++ b/lib/tst_test.c > > @@ -34,6 +34,7 @@ > > #include "old_resource.h" > > #include "old_device.h" > > #include "old_tmpdir.h" > > +#include "ltp-version.h" > > /* > > * Hack to get TCID defined in newlib tests > > @@ -509,6 +510,7 @@ static struct option { > > {"h", "-h Prints this help"}, > > {"i:", "-i n Execute test n times"}, > > {"I:", "-I x Execute test for n seconds"}, > > + {"V", "-V Prints LTP version"}, > > {"C:", "-C ARG Run child process with ARG arguments (used internally)"}, > > }; > > @@ -686,6 +688,10 @@ static void parse_opts(int argc, char *argv[]) > > else > > duration = SAFE_STRTOF(optarg, 0.1, HUGE_VALF); > > break; > > + case 'V': > > + fprintf(stderr, "LTP version: " LTP_VERSION "\n"); > > + exit(0); > > + break; > > case 'C': > > #ifdef UCLINUX > > child_args = optarg; > > -- > > 2.40.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp