From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] tst_netdevice: Add helper functions for qdisc and filter management
Date: Fri, 28 Jul 2023 14:09:12 +0200 [thread overview]
Message-ID: <20230728120912.GB19163@pevik> (raw)
In-Reply-To: <20230727150013.31835-2-mdoucha@suse.cz>
Hi Martin,
...
nit: missing comment here, but the meaning is obvious. Also
NETDEV_REMOVE_TRAFFIC_CLASS() (and tst_netdev_remove_traffic_filter()) look to
be unused, but I guess you expect to use it in another reproducer.
> +int tst_netdev_remove_traffic_class(const char *file, const int lineno,
> + const char *ifname, unsigned int parent, unsigned int handle,
> + const char *qd_kind);
> +#define NETDEV_REMOVE_TRAFFIC_CLASS(ifname, parent, handle, qd_kind) \
> + tst_netdev_remove_traffic_class(__FILE__, __LINE__, (ifname), \
> + (parent), (handle), (qd_kind))
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-28 12:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:00 [LTP] [PATCH 1/3] tst_netdevice: Add missing rtnetlink context allocation checks Martin Doucha
2023-07-27 15:00 ` [LTP] [PATCH 2/3] tst_netdevice: Add helper functions for qdisc and filter management Martin Doucha
2023-07-28 7:53 ` Cyril Hrubis
2023-07-28 8:21 ` Martin Doucha
2023-07-28 12:09 ` Petr Vorel [this message]
2023-07-27 15:00 ` [LTP] [PATCH 3/3] Add test for CVE 2023-1829 Martin Doucha
2023-07-28 8:36 ` Petr Vorel
2023-08-03 12:51 ` Cyril Hrubis
2023-08-04 9:23 ` Martin Doucha
2023-07-28 7:46 ` [LTP] [PATCH 1/3] tst_netdevice: Add missing rtnetlink context allocation checks Cyril Hrubis
2023-07-28 8:17 ` Martin Doucha
2023-07-28 8:45 ` Cyril Hrubis
2023-07-28 11:43 ` Petr Vorel
2023-08-04 13:28 ` [LTP] [PATCH v2 3/3] Add test for CVE 2023-1829 Martin Doucha
2023-08-04 13:38 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728120912.GB19163@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox