public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Add process_madvise01 test
Date: Fri, 1 Sep 2023 14:31:26 +0200	[thread overview]
Message-ID: <20230901123126.GA343678@pevik> (raw)
In-Reply-To: <ZPHWK_Msrqbpmvtt@yuki>

> Hi!
> > > > +	TST_EXP_EXPR(map_before.swap < map_after.swap,
> > > > +		"Most of the memory has been swapped out: %dkB out of %dkB",
> > > > +		map_after.swap,

> > > Although it's unlikely that map_before.swap will be non-zero we should
> > > print the difference here, so I've changed this part to:

> > > map_after.swap - map_before.swap

> > > And pushed, thanks.

> > FYI this new test is failing on current openSUSE Tumbleweed (kernel 6.4.12-1):

> > tst_test.c:1559: TINFO: Timeout per run is 0h 00m 30s
> > process_madvise01.c:38: TINFO: Allocate memory: 1048576 bytes
> > process_madvise01.c:99: TINFO: Reclaim memory using MADV_PAGEOUT
> > process_madvise01.c:62: TFAIL: Expect: Most of the memory has been swapped out: 0kB out of 1024kB

> > Summary:
> > passed   0
> > failed   1
> > broken   0
> > skipped  0
> > warnings 0

> > Test works well on current Debian unstable with kernel 6.4.11.
> > Could you please have a look if it's a test or a kernel bug?

> Does the machine where it fails even have any swap?

I has CONFIG_SWAP=y, but vmstat reports si and so as 0.
Therefore machine probably does not have any swap.

> I suppose that we should check for:

> 1) CONFIG_SWAP in the kernel .config
> 2) /proc/meminfo SwapFree: > $pagesize kB

+1.

> I guess that the madvise kicks off the kernel swapper, but it may take
> some time for the memory to be actually swapped.

Sounds reasonable.

BTW I wonder if we should add 'vmstat' or 'cat /proc/meminfo' to ver_linux.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-09-01 12:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  7:38 [LTP] [PATCH v3] Add process_madvise01 test Andrea Cervesato
2023-08-30 10:45 ` Cyril Hrubis
2023-09-01 10:37   ` Petr Vorel
2023-09-01 12:16     ` Cyril Hrubis
2023-09-01 12:31       ` Petr Vorel [this message]
2023-09-01 12:36         ` Cyril Hrubis
2023-09-01 12:52           ` Andrea Cervesato via ltp
2023-09-01 12:53             ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230901123126.GA343678@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox