From: R Nageswara Sastry <rnsastry@linux.ibm.com>
To: ltp@lists.linux.it
Cc: rnsastry@linux.ibm.com
Subject: [LTP] [PATCH v3] lib/tst_lockdown.c: Add PPC64 architecture support
Date: Thu, 7 Sep 2023 10:10:10 +0530 [thread overview]
Message-ID: <20230907044011.4812-1-rnsastry@linux.ibm.com> (raw)
From: Nageswara R Sastry <rnsastry@linux.ibm.com>
Add PPC64 architecture support to the lockdown library.
Signed-off-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
---
v3:
- Revert back the kernel config checking to v1 (Martin Doucha)
v2:
- Group all the constant definitions together (Cyril Hrubis)
- Reduce the number of variables (Martin Doucha)
---
lib/tst_lockdown.c | 31 +++++++++++++++++++++----------
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/lib/tst_lockdown.c b/lib/tst_lockdown.c
index 9086eba36..3ccf73092 100644
--- a/lib/tst_lockdown.c
+++ b/lib/tst_lockdown.c
@@ -14,33 +14,37 @@
#include "tst_lockdown.h"
#include "tst_private.h"
-#define EFIVAR_SECUREBOOT "/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c"
-
+#if defined(__powerpc64__) || defined(__ppc64__)
+# define SECUREBOOT_VAR "/proc/device-tree/ibm,secure-boot"
+# define VAR_DATA_SIZE 4
+#else
+# define SECUREBOOT_VAR "/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c"
+# define VAR_DATA_SIZE 5
+#endif
int tst_secureboot_enabled(void)
{
int fd;
char data[5];
- if (access(EFIVAR_SECUREBOOT, F_OK)) {
- tst_res(TINFO, "Efivar FS not available");
+ if (access(SECUREBOOT_VAR, F_OK)) {
+ tst_res(TINFO, "SecureBoot sysfs file not available");
return -1;
}
- fd = open(EFIVAR_SECUREBOOT, O_RDONLY);
+ fd = open(SECUREBOOT_VAR, O_RDONLY);
if (fd == -1) {
tst_res(TINFO | TERRNO,
- "Cannot open SecureBoot Efivar sysfile");
+ "Cannot open SecureBoot file");
return -1;
} else if (fd < 0) {
tst_brk(TBROK | TERRNO, "Invalid open() return value %d", fd);
return -1;
}
-
- SAFE_READ(1, fd, data, 5);
+ SAFE_READ(1, fd, data, VAR_DATA_SIZE);
SAFE_CLOSE(fd);
- tst_res(TINFO, "SecureBoot: %s", data[4] ? "on" : "off");
- return data[4];
+ tst_res(TINFO, "SecureBoot: %s", data[VAR_DATA_SIZE - 1] ? "on" : "off");
+ return data[VAR_DATA_SIZE - 1];
}
int tst_lockdown_enabled(void)
@@ -51,9 +55,16 @@ int tst_lockdown_enabled(void)
if (access(PATH_LOCKDOWN, F_OK) != 0) {
char flag;
+
/* SecureBoot enabled could mean integrity lockdown (non-mainline version) */
+#if defined(__powerpc64__) || defined(__ppc64__)
+ flag = tst_kconfig_get("CONFIG_SECURITY_LOCKDOWN_LSM") == 'y';
+ flag |= tst_kconfig_get("CONFIG_SECURITY_LOCKDOWN_LSM_EARLY") == 'y';
+#else
flag = tst_kconfig_get("CONFIG_EFI_SECURE_BOOT_LOCK_DOWN") == 'y';
flag |= tst_kconfig_get("CONFIG_LOCK_DOWN_IN_EFI_SECURE_BOOT") == 'y';
+#endif
+
if (flag && tst_secureboot_enabled() > 0)
return 1;
--
2.37.1 (Apple Git-137.1)
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-09-07 4:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 4:40 R Nageswara Sastry [this message]
2023-09-07 11:13 ` [LTP] [PATCH v3] lib/tst_lockdown.c: Add PPC64 architecture support Martin Doucha
2023-09-07 11:46 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907044011.4812-1-rnsastry@linux.ibm.com \
--to=rnsastry@linux.ibm.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox