public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Replace runltp-ng with kirk framework
Date: Fri, 15 Sep 2023 13:50:50 +0200	[thread overview]
Message-ID: <20230915115050.GA18941@pevik> (raw)
In-Reply-To: <cbfb41c4-9ec5-494d-9b86-1e67d7e16703@suse.com>

> Hi,

> On 9/15/23 13:19, Petr Vorel wrote:
> > Hi Cyril, Andrea,

> > > Hi!
> > > > Kirk application is a fork of runltp-ng and it aims to merge multiple
> > > > Linux testing frameworks in one tool, providing support for remote
> > > > testing via Qemu, SSH, LTX, parallel execution and much more.
> > > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > > > ---
> > > >   .gitmodules     | 6 +++---
> > > >   tools/kirk      | 1 +
> > > >   tools/runltp-ng | 1 -
> > > Do we also want symlink from runltp-ng to kirk?
> > +1

> > BTW I suggested Andrea in the beginning of kirk to have runltp-ng symlink,
> > which would behave like 'kirk --framework ltp'. I.e. this:

> > ./kirk --framework ltp --run-suite syscalls

> > would be equivalent of

> > ./runltp-ng --run-suite syscalls

> > Instead of having to run:
> > ./runltp-ng --framework ltp --run-suite syscalls

> > In that case kirk would be a drop in replacement.
> > Andrea, would it be possible to implement this functionality?
> > (the default framework could be detected by symlink name, the same approach
> > busybox uses, more symlinks could be added).

> > Kind regards,
> > Petr

> The default kirk behavior is to use '--framework ltp' by default, so there's
> no difference between

> ./kirk --framework ltp --run-suite syscalls

> and

> ./kirk --run-suite syscalls

Great, then OK from my side. With adding the symlink:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
(please send v2).

I'm for replacing runltp-ng with kirk before the release.
I guess Cyril will highlight it in the changelog and then we should replace all
files in the runltp-ng repo with simple README.md, which points to kirk git
repo.

I'd still recommend to implement the default framework functionality (kselftest
and liburing would benefit from it), but that can be added later.

Kind regards,
Petr

> Regards,
> Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2023-09-15 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  9:15 [LTP] [PATCH v1] Replace runltp-ng with kirk framework Andrea Cervesato
2023-09-15 10:56 ` Cyril Hrubis
2023-09-15 11:19   ` Petr Vorel
2023-09-15 11:29     ` Andrea Cervesato via ltp
2023-09-15 11:50       ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915115050.GA18941@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox