public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Add Linux Test eXecutor inside tools
Date: Fri, 15 Sep 2023 17:41:35 +0200	[thread overview]
Message-ID: <20230915154135.GA11318@pevik> (raw)
In-Reply-To: <20230915152910.GB73280@pevik>

Hi Andrea,

> Hi Andrea,

> Reviewed-by: Petr Vorel <pvorel@suse.cz>

This is breaking build:

2023-09-15T13:47:12.1128844Z make -C ltx
2023-09-15T13:47:12.1148029Z make[3]: *** No targets specified and no makefile found.  Stop.
2023-09-15T13:47:12.1153175Z make[2]: *** [/__w/ltp/ltp/tools/ltx/Makefile:13: all] Error 2
2023-09-15T13:47:12.1159251Z make[1]: *** [../include/mk/generic_trunk_target.inc:108: all] Error 2
2023-09-15T13:47:12.1163512Z make[1]: Leaving directory '/__w/ltp/ltp/tools'
2023-09-15T13:47:12.1169815Z make: *** [Makefile:94: tools-all] Error 2

Reproduce with simple:
$ cd tools && make -C ltx

The problem is because there is no tools/ltx/Makefile

Why are the sources in tools/ltx/ltx-src instead of tools/ltx anyway?
I guess you used sparse approach, which is not necessary here.
I'm ok with that if it makes things simpler, but please include the required
Makefile.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-09-15 15:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 14:41 [LTP] [PATCH v2 0/2] Add kirk & ltx tools Andrea Cervesato
2023-09-15 14:41 ` [LTP] [PATCH v2 1/2] Replace runltp-ng with kirk framework Andrea Cervesato
2023-09-15 15:27   ` Petr Vorel
2023-09-15 16:43     ` Cyril Hrubis
2023-09-15 14:41 ` [LTP] [PATCH v2 2/2] Add Linux Test eXecutor inside tools Andrea Cervesato
2023-09-15 15:29   ` Petr Vorel
2023-09-15 15:41     ` Petr Vorel [this message]
2023-09-15 16:41       ` Cyril Hrubis
2023-09-15 18:22         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915154135.GA11318@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox