Re: [LTP] [PATCH v2 1/2] Replace runltp-ng with kirk framework

Petr Vorel
2023-09-15T15:28:01Z

Hi Andrea,

> From: Andrea Cervesato <andrea.cervesato@suse.com>

> Kirk application is a fork of runltp-ng and it aims to merge multiple
> Linux testing frameworks in one tool, providing support for remote
> testing via Qemu, SSH, LTX, parallel execution and much more.
Maybe s/fork/successor/ ?

I'd note here, that kirk is based on runltp-ng and deprecating runltp-ng
(just to be obvious that it's not a huge change). Also I'd note there is a
backwards compatibility with runltp-ng.

> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
> .gitmodules | 6 +++---
> tools/kirk | 1 +
> tools/runltp-ng | 1 -
> 3 files changed, 4 insertions(+), 4 deletions(-)
> create mode 160000 tools/kirk
> delete mode 160000 tools/runltp-ng

> diff --git a/.gitmodules b/.gitmodules
> index d1d558b9e..088023039 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -4,6 +4,6 @@
> [submodule "tools/sparse/sparse-src"]
> path = tools/sparse/sparse-src
> url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git
> -[submodule "tools/runltp-ng"]
> - path = tools/runltp-ng
> - url = https://github.com/linux-test-project/runltp-ng.git
> +[submodule "tools/kirk"]
> + path = tools/kirk
> + url = https://github.com/linux-test-project/kirk.git
> diff --git a/tools/kirk b/tools/kirk
> new file mode 160000
> index 000000000..805c56c2a
> --- /dev/null
> +++ b/tools/kirk
> @@ -0,0 +1 @@
> +Subproject commit 805c56c2a69b2e9f24ba13f64eab1bdad5885678
Why not add the master HEAD c7419dd ("Fix qemu login prompt recognition")?

https://github.com/linux-test-project/kirk/commit/c7419dd6f73d90f3f02aa17d30270e895e30c88e

IMHO it'd be better to use it, instead of 805c56c (HEAD~).

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> diff --git a/tools/runltp-ng b/tools/runltp-ng
> deleted file mode 160000
> index e842511ed..000000000
> --- a/tools/runltp-ng
> +++ /dev/null
> @@ -1 +0,0 @@
> -Subproject commit e842511ed2c680e3b2ea6dec790913a41d5ed937