From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] Replace runltp-ng with kirk framework
Date: Mon, 18 Sep 2023 11:01:36 +0200 [thread overview]
Message-ID: <20230918090136.GA30304@pevik> (raw)
In-Reply-To: <20230918082506.17464-2-andrea.cervesato@suse.de>
Hi Andrea,
...
> +++ b/.gitmodules
> @@ -7,3 +7,6 @@
> [submodule "tools/runltp-ng"]
> path = tools/runltp-ng
> url = https://github.com/linux-test-project/runltp-ng.git
> +[submodule "tools/kirk"]
> + path = tools/kirk
> + url = https://github.com/linux-test-project/kirk.git
I'm not sure if anybody asked you to keep runltp-ng, but I'd prefer to remove
runltp-ng as you did in v2. I don't think runltp-ng was really adopted a lot
We should have runltp-ng symlink to kirk at least in LTP:
cd tools/kirk && make install
install -m 00644 ../../tools/kirk/libkirk/*.py /opt/ltp/libkirk
install -m 00775 ../../tools/kirk/kirk /opt/ltp/kirk
...
Here I would add
ln -s /opt/ltp/kirk /opt/ltp/runltp-ng
...
> +++ b/tools/kirk
> @@ -0,0 +1 @@
> +Subproject commit c7419dd6f73d90f3f02aa17d30270e895e30c88e
+1 for fixing this.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-18 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:25 [LTP] [PATCH v3 0/2] Add kirk & ltx tools Andrea Cervesato
2023-09-18 8:25 ` [LTP] [PATCH v3 1/2] Replace runltp-ng with kirk framework Andrea Cervesato
2023-09-18 9:01 ` Petr Vorel [this message]
2023-09-18 9:06 ` Andrea Cervesato via ltp
2023-09-18 8:25 ` [LTP] [PATCH v3 2/2] Add Linux Test eXecutor inside tools Andrea Cervesato
2023-09-18 9:17 ` Petr Vorel
2023-09-18 9:35 ` Andrea Cervesato via ltp
2023-09-18 9:38 ` Cyril Hrubis
2023-09-18 9:42 ` Cyril Hrubis
2023-09-18 10:34 ` Petr Vorel
2023-09-18 10:37 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918090136.GA30304@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox