From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 2/2] Add Linux Test eXecutor inside tools
Date: Mon, 18 Sep 2023 12:37:27 +0200 [thread overview]
Message-ID: <20230918103727.GB12384@pevik> (raw)
In-Reply-To: <ZQgarkBUEyDd4lxF@yuki>
> Hi!
> > This works, but why we don't use approach used for sparc, i.e.
> > $(MAKE) -C ltx-src
> > That way we would not have to redefine the default rules.
> Unfortunately this does not work well either because the ltx does not
> have install targed and trying to install a file from a subdirectory is
> not possible with the LTP build system. I've tried that and it didn't
> work.
> Let's merge this version that works, we can try to do make things better
> later on.
Sure. BTW I prefer v4, which replaces runltp-ng instead of keeping it.
> > Also it detects missing git clone and runs
> > git submodule update --init if needed.
> > I'm asking for a same approach, not only because later we can unify and reuse
> > the code in some make helper, but also because it'd be more user friendly if our
> > new git submodules work the same way.
> Now this needs to be discussed first. Currently the submodule is
> installed when user writes make check. That means that it's not
> triggered in default build and the default build works without network
> connection. I do not think that we should attempt to download additional
> repositories on default build.
Make sense.
> > But if there is not enough time before release I would not be against this.
> I'm would say that there is not enough time for a proper discussion, so
> I would really keep things as they are in the latest patchset and leave
> the discussion for later.
Sure.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-09-18 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:25 [LTP] [PATCH v3 0/2] Add kirk & ltx tools Andrea Cervesato
2023-09-18 8:25 ` [LTP] [PATCH v3 1/2] Replace runltp-ng with kirk framework Andrea Cervesato
2023-09-18 9:01 ` Petr Vorel
2023-09-18 9:06 ` Andrea Cervesato via ltp
2023-09-18 8:25 ` [LTP] [PATCH v3 2/2] Add Linux Test eXecutor inside tools Andrea Cervesato
2023-09-18 9:17 ` Petr Vorel
2023-09-18 9:35 ` Andrea Cervesato via ltp
2023-09-18 9:38 ` Cyril Hrubis
2023-09-18 9:42 ` Cyril Hrubis
2023-09-18 10:34 ` Petr Vorel
2023-09-18 10:37 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918103727.GB12384@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox