From: Marius Kittler <mkittler@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 4/4] Use termios instead of legacy struct in ioctl02.c
Date: Tue, 19 Sep 2023 12:24:45 +0200 [thread overview]
Message-ID: <20230919102445.23934-5-mkittler@suse.de> (raw)
In-Reply-To: <20230919102445.23934-1-mkittler@suse.de>
Signed-off-by: Marius Kittler <mkittler@suse.de>
---
testcases/kernel/syscalls/ioctl/ioctl02.c | 24 +++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/testcases/kernel/syscalls/ioctl/ioctl02.c b/testcases/kernel/syscalls/ioctl/ioctl02.c
index b4db6ba86..c9a1c32d0 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl02.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl02.c
@@ -8,17 +8,17 @@
/*\
* [Description]
*
- * Testcase to test the TCGETA, and TCSETA ioctl implementations for
+ * Testcase to test the TCGETS, and TCSETS ioctl implementations for
* the tty driver
*
* In this test, the parent and child open the parentty and the childtty
* respectively. After opening the childtty the child flushes the stream
* and wakes the parent (thereby asking it to continue its testing). The
- * parent, then starts the testing. It issues a TCGETA ioctl to get all
+ * parent, then starts the testing. It issues a TCGETS ioctl to get all
* the tty parameters. It then changes them to known values by issuing a
- * TCSETA ioctl. Then the parent issues a TCGETA ioctl again and compares
+ * TCSETS ioctl. Then the parent issues a TCGETS ioctl again and compares
* the received values with what it had set earlier. The test fails if
- * TCGETA or TCSETA fails, or if the received values don't match those
+ * TCGETS or TCSETS fails, or if the received values don't match those
* that were set. The parent does all the testing, the requirement of the
* child process is to moniter the testing done by the parent, and hence
* the child just waits for the parent.
@@ -37,7 +37,7 @@
#include "tst_test.h"
#include "tst_safe_macros.h"
-static struct termio termio, save_io;
+static struct termios termio, save_io;
static char *parenttty, *childtty;
static int parentfd = -1, childfd = -1;
@@ -76,10 +76,10 @@ static void verify_ioctl(void)
int rval = run_ptest();
if (rval != 0)
- tst_res(TFAIL, "TCGETA/TCSETA tests FAILED with "
+ tst_res(TFAIL, "TCGETS/TCSETS tests FAILED with "
"%d %s", rval, rval > 1 ? "errors" : "error");
else
- tst_res(TPASS, "TCGETA/TCSETA tests SUCCEEDED");
+ tst_res(TPASS, "TCGETS/TCSETS tests SUCCEEDED");
TST_CHECKPOINT_WAKE(checkpoint_parent_done_testing);
}
@@ -95,7 +95,7 @@ static void do_child(void)
/*
* run_ptest() - setup the various termio structure values and issue
- * the TCSETA ioctl call with the TEST macro.
+ * the TCSETS ioctl call with the TEST macro.
*/
static int run_ptest(void)
{
@@ -124,10 +124,10 @@ static int run_ptest(void)
/* Set output modes. */
termio.c_oflag = OPOST | OLCUC | ONLCR | ONOCR;
- SAFE_IOCTL(parentfd, TCSETA, &termio);
+ SAFE_IOCTL(parentfd, TCSETS, &termio);
/* Get termio and see if all parameters actually got set */
- SAFE_IOCTL(parentfd, TCGETA, &termio);
+ SAFE_IOCTL(parentfd, TCGETS, &termio);
return chk_tty_parms();
}
@@ -215,7 +215,7 @@ static void setup(void)
int fd = SAFE_OPEN(device, O_RDWR, 0777);
/* Save the current device information - to be restored in cleanup() */
- SAFE_IOCTL(fd, TCGETA, &save_io);
+ SAFE_IOCTL(fd, TCGETS, &save_io);
/* Close the device */
SAFE_CLOSE(fd);
@@ -224,7 +224,7 @@ static void setup(void)
static void cleanup(void)
{
if (parentfd >= 0) {
- SAFE_IOCTL(parentfd, TCSETA, &save_io);
+ SAFE_IOCTL(parentfd, TCSETS, &save_io);
SAFE_CLOSE(parentfd);
}
}
--
2.42.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-09-19 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 10:24 [LTP] [PATCH v5 0/4] Improve ioctl02.c Marius Kittler
2023-09-19 10:24 ` [LTP] [PATCH v5 1/4] Refactor ioctl02.c to use the new test API Marius Kittler
2023-09-19 10:24 ` [LTP] [PATCH v5 2/4] Make checks for termio flags more strict Marius Kittler
2023-09-19 10:24 ` [LTP] [PATCH v5 3/4] Remove disabled code in ioctl02.c Marius Kittler
2023-09-19 10:24 ` Marius Kittler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919102445.23934-5-mkittler@suse.de \
--to=mkittler@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox