public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v9 1/4] Refactor mqns_03 using new LTP API
Date: Wed, 20 Sep 2023 09:55:14 +0200	[thread overview]
Message-ID: <20230920075514.GA208385@pevik> (raw)
In-Reply-To: <ZQLgv0WWc7bTMRyD@yuki>

Hi Andrea, Cyril,

> Hi!
> Since we are getting close to release I've fixed the remaining problems
> and pushed, thanks.

> What I fixed:

> - runtest entries were not updated
> - license did not match the original
> - there was no need for asprintf() for statically defined strings
> - the mq_freed was set but not used, so I've removed it
> - changed the SAFE_STAT() to access() so that we have clear TPASS/TFAIL
>   messages

I found that mqns_03.c and mqns_04.c fails on Debian in cleanup, when they try
to unmont DEVDIR:

static void cleanup(void)
{
	if (!access(MQUEUE1, F_OK))
		SAFE_MQ_UNLINK(MQNAME1);

	if (!access(MQUEUE2, F_OK))
		SAFE_MQ_UNLINK(MQNAME2);

	if (tst_is_mounted(DEVDIR))
		SAFE_UMOUNT(DEVDIR);
}

While on some distros (e.g. Tumbleweed) it's already unmounted in cleanup, thus
it just warns:
mqns_03.c:88: TINFO: Umounting /tmp/LTP_mqniOxGTg/ltp_mqueue
tst_device.c:442: TINFO: No device is mounted at ltp_mqueue

on Debian it's mounted and fail with EINVAL:
mqns_03.c:136: TINFO: Umounting /tmp/LTP_mqniOxGTg/ltp_mqueue
tst_device.c:402: TWARN: umount('ltp_mqueue') failed with EINVAL
mqns_03.c:136: TWARN: umount(ltp_mqueue) failed: EINVAL (22)

Any idea what can cause this?
(it's a regression)

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-09-20  7:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 14:47 [LTP] [PATCH v9 0/4] Refactor mqns testing suite Andrea Cervesato
2023-09-13 14:47 ` [LTP] [PATCH v9 1/4] Refactor mqns_03 using new LTP API Andrea Cervesato
2023-09-14 10:30   ` Cyril Hrubis
2023-09-20  7:55     ` Petr Vorel [this message]
2023-09-13 14:47 ` [LTP] [PATCH v9 2/4] Refactor mqns_04 " Andrea Cervesato
2023-09-14 11:09   ` Cyril Hrubis
2023-09-13 14:47 ` [LTP] [PATCH v9 3/4] Remove deprecated header files from mqns suite Andrea Cervesato
2023-09-14 12:14   ` Cyril Hrubis
2023-09-13 14:47 ` [LTP] [PATCH v9 4/4] Remove libclone dependency " Andrea Cervesato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920075514.GA208385@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox