Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails

Petr Vorel
2023-09-20T08:01:39Z

Hi Martin,

> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index a996f7cc8..099c78759 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -214,7 +214,7 @@ nfs_cleanup()
> local_dir="$(get_local_dir $i $n)"
> if grep -q "$local_dir" /proc/mounts; then
> tst_res TINFO "Unmounting $local_dir"
> - umount $local_dir
> + umount $local_dir || tst_res TFAIL "Unmount failed"

I'd personally add TWARN (i.e. less critical error).
@Cyril WDYT?

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> fi
> n=$(( n + 1 ))
> done