From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B62CCE79AB for ; Wed, 20 Sep 2023 08:01:39 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8DAD43CDED2 for ; Wed, 20 Sep 2023 10:01:37 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 5C5BA3C8AE1 for ; Wed, 20 Sep 2023 10:01:25 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id CC189615C0C for ; Wed, 20 Sep 2023 10:01:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D2A4226EA; Wed, 20 Sep 2023 08:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1695196884; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WR5odR3Y9WNlDy9LohTosliVcGMAfNgiPQNkktJ/Ilo=; b=L84Br1lA6eGsaWFwL1FGyqV9CxpaSVQsQ6E9RSYiNdTXx/U6l82HR2fS8nL4sZqxlDoMyp MkvsO2QnccmlTTxXsdlaSZaQwDbySmh7quVTFEJDTtmnwRP7buXViS1diFj1eR3XKsgdpt LJ+OFtZuNph+YUlz9IZDgIbO4mwBlG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1695196884; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WR5odR3Y9WNlDy9LohTosliVcGMAfNgiPQNkktJ/Ilo=; b=mfDOp6PmE0lGd6JIZvApQYuW4bgfgk0hiCJAs9kUZz94pbkZ2+ctKa3pmrw9K5u6ZnnEnt tQLBfpWF2FocGZDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CEF7132C7; Wed, 20 Sep 2023 08:01:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KyO6BNSmCmUhRgAAMHmgww (envelope-from ); Wed, 20 Sep 2023 08:01:24 +0000 Date: Wed, 20 Sep 2023 10:01:22 +0200 From: Petr Vorel To: Martin Doucha Message-ID: <20230920080122.GC281877@pevik> References: <20230919114701.15327-1-mdoucha@suse.cz> <20230919114701.15327-4-mdoucha@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230919114701.15327-4-mdoucha@suse.cz> X-Virus-Scanned: clamav-milter 1.0.1 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Martin, > Signed-off-by: Martin Doucha > --- > testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh > index a996f7cc8..099c78759 100644 > --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh > +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh > @@ -214,7 +214,7 @@ nfs_cleanup() > local_dir="$(get_local_dir $i $n)" > if grep -q "$local_dir" /proc/mounts; then > tst_res TINFO "Unmounting $local_dir" > - umount $local_dir > + umount $local_dir || tst_res TFAIL "Unmount failed" I'd personally add TWARN (i.e. less critical error). @Cyril WDYT? Reviewed-by: Petr Vorel Kind regards, Petr > fi > n=$(( n + 1 )) > done -- Mailing list info: https://lists.linux.it/listinfo/ltp