From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
Date: Mon, 25 Sep 2023 15:24:49 +0200 [thread overview]
Message-ID: <20230925132449.GD60471@pevik> (raw)
In-Reply-To: <ZQ2Dth3NZO2rhzXP@yuki>
> Hi!
> > diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > index a996f7cc8..099c78759 100644
> > --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > @@ -214,7 +214,7 @@ nfs_cleanup()
> > local_dir="$(get_local_dir $i $n)"
> > if grep -q "$local_dir" /proc/mounts; then
> > tst_res TINFO "Unmounting $local_dir"
> > - umount $local_dir
> > + umount $local_dir || tst_res TFAIL "Unmount failed"
> I suppose that this should be TBROK instead. And that this, apart from
Right, TBROK looks to be the best.
Martin, if you're ok with the change, I'll update it before merge (after the
release).
Kind regards,
Petr
> the previous patches, should be applied after the release.
> Otherwise:
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-25 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-20 7:59 ` Petr Vorel
2023-09-20 11:26 ` Richard Palethorpe
2023-09-22 12:02 ` Cyril Hrubis
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
2023-09-20 10:50 ` Martin Doucha
2023-09-20 8:00 ` Petr Vorel
2023-09-20 11:28 ` Richard Palethorpe
2023-09-22 12:05 ` Cyril Hrubis
2023-09-25 13:22 ` Petr Vorel
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2023-09-20 8:01 ` Petr Vorel
2023-09-20 11:27 ` Richard Palethorpe
2023-09-22 12:08 ` Cyril Hrubis
2023-09-25 13:24 ` Petr Vorel [this message]
2023-09-25 13:45 ` Martin Doucha
2023-09-25 17:40 ` Petr Vorel
2023-11-13 15:46 ` Martin Doucha
2023-11-13 15:49 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925132449.GD60471@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox