Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails

Petr Vorel
2023-09-25T13:25:03Z

> Hi!
> > diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > index a996f7cc8..099c78759 100644
> > --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > @@ -214,7 +214,7 @@ nfs_cleanup()
> > local_dir="$(get_local_dir $i $n)"
> > if grep -q "$local_dir" /proc/mounts; then
> > tst_res TINFO "Unmounting $local_dir"
> > - umount $local_dir
> > + umount $local_dir || tst_res TFAIL "Unmount failed"

> I suppose that this should be TBROK instead. And that this, apart from

Right, TBROK looks to be the best.
Martin, if you're ok with the change, I'll update it before merge (after the
release).

Kind regards,
Petr

> the previous patches, should be applied after the release.

> Otherwise:

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>