Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails

Martin Doucha
2023-09-25T13:45:37Z

On 25. 09. 23 15:24, Petr Vorel wrote:
>> Hi!
>>> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
>>> index a996f7cc8..099c78759 100644
>>> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
>>> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
>>> @@ -214,7 +214,7 @@ nfs_cleanup()
>>> local_dir="$(get_local_dir $i $n)"
>>> if grep -q "$local_dir" /proc/mounts; then
>>> tst_res TINFO "Unmounting $local_dir"
>>> - umount $local_dir
>>> + umount $local_dir || tst_res TFAIL "Unmount failed"
>
>> I suppose that this should be TBROK instead. And that this, apart from
>
> Right, TBROK looks to be the best.
> Martin, if you're ok with the change, I'll update it before merge (after the
> release).
I don't see the point. This is a cleanup function. The TBROK will be
changed to TWARN and the test will continue anyway.

--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic