From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence
Date: Tue, 26 Sep 2023 17:21:55 +0200 [thread overview]
Message-ID: <20230926152155.GE159673@pevik> (raw)
In-Reply-To: <ZRLn7-PoVhomEB-v@yuki>
> Hi!
> > Maybe this sanity check is useless. WDYT?
> I guess that it does not harm.
Thanks for your review!
> > testcases/kernel/mem/vma/vma05.sh | 2 ++
> > 1 file changed, 2 insertions(+)
> > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> > index c9e4becdb..30b1d689a 100755
> > --- a/testcases/kernel/mem/vma/vma05.sh
> > +++ b/testcases/kernel/mem/vma/vma05.sh
> > @@ -54,6 +54,8 @@ vma_report_check()
> > rm -rf core*
> > { vma05_vdso; } > /dev/null 2>&1
> > + [ -f core ] || tst_brk TCONF "missing core file"
> TCONF or TBROK that is the question.
I guess TBROK is better in this case. I wonder myself why I type TCONF.
If nobody complains, I'll merge this with TBROK and your ack.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-26 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:46 [LTP] [PATCH 0/2] Fix vma05.sh on $DEBUGINFOD_URLS Petr Vorel
2023-09-26 12:46 ` [LTP] [PATCH 1/2] vma05.sh: Add workaround for gdb debuginfod question Petr Vorel
2023-09-26 14:12 ` Cyril Hrubis
2023-09-27 5:37 ` Petr Vorel
2023-09-26 12:46 ` [LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence Petr Vorel
2023-09-26 14:17 ` Cyril Hrubis
2023-09-26 15:21 ` Petr Vorel [this message]
2023-10-26 9:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926152155.GE159673@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox