[LTP] [PATCH 0/2] Fix vma05.sh on $DEBUGINFOD_URLS

[LTP] [PATCH 0/2] Fix vma05.sh on $DEBUGINFOD_URLS

[Petr Vorel]

Hi,

first patch is a candidate for pre-release fix.
Second commit is not strictly needed.

Kind regards,
Petr

Petr Vorel (2):
  vma05.sh: Add workaround for gdb debuginfod question
  vma05.sh: Add check for core file presence

 testcases/kernel/mem/vma/vma05.sh | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.40.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/2] vma05.sh: Add workaround for gdb debuginfod question

[Petr Vorel]

gdb asks if $DEBUGINFOD_URLS is set and there is no 'set debuginfod enabled on|off'
config in ~/.gdbinit:

    # echo $DEBUGINFOD_URLS
    https://debuginfod.opensuse.org/

    # grep 'set debuginfod enabled' ~/.gdbinit
    grep: /root/.gdbinit: No such file or directory

    # gdb -silent -ex="thread apply all backtrace" -ex="quit" vma05_vdso ./core*
    Segmentation fault (core dumped)
    Reading symbols from vma05_vdso...
    [New LWP 6070]

    This GDB supports auto-downloading debuginfo from the following URLs:
      <https://debuginfod.opensuse.org/>
    Enable debuginfod for this session? (y or [n])

Therefore disable this question with unsetting $DEBUGINFOD_URLS.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
A candidate for pre-release fix.

Kind regards,
Petr

 testcases/kernel/mem/vma/vma05.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
index 9ef6f0a23..c9e4becdb 100755
--- a/testcases/kernel/mem/vma/vma05.sh
+++ b/testcases/kernel/mem/vma/vma05.sh
@@ -30,6 +30,7 @@ setup()
 {
 	ulimit -c unlimited
 	echo "core" > /proc/sys/kernel/core_pattern
+	unset DEBUGINFOD_URLS
 }
 
 cleanup()
-- 
2.40.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] vma05.sh: Add workaround for gdb debuginfod question

[Cyril Hrubis]

Hi!
> A candidate for pre-release fix.

Looks simple enough for the release.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] vma05.sh: Add workaround for gdb debuginfod question

[Petr Vorel]

Hi Cyril,

> Hi!
> > A candidate for pre-release fix.

> Looks simple enough for the release.
Thanks, this first patch merged to get Tumbleweed fixed.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence

[Petr Vorel]

Because we redirect gdb output, add sanity check for core file being
created.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Maybe this sanity check is useless. WDYT?

Kind regards,
Petr

 testcases/kernel/mem/vma/vma05.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
index c9e4becdb..30b1d689a 100755
--- a/testcases/kernel/mem/vma/vma05.sh
+++ b/testcases/kernel/mem/vma/vma05.sh
@@ -54,6 +54,8 @@ vma_report_check()
 
 	rm -rf core*
 	{ vma05_vdso; } > /dev/null 2>&1
+	[ -f core ] || tst_brk TCONF "missing core file"
+
 	TRACE=$(gdb -silent -ex="thread apply all backtrace" -ex="quit"\
 		vma05_vdso ./core* 2> /dev/null)
 	if echo "$TRACE" | grep -qF "??"; then
-- 
2.40.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence

[Cyril Hrubis]

Hi!
> Maybe this sanity check is useless. WDYT?

I guess that it does not harm.

>  testcases/kernel/mem/vma/vma05.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> index c9e4becdb..30b1d689a 100755
> --- a/testcases/kernel/mem/vma/vma05.sh
> +++ b/testcases/kernel/mem/vma/vma05.sh
> @@ -54,6 +54,8 @@ vma_report_check()
>  
>  	rm -rf core*
>  	{ vma05_vdso; } > /dev/null 2>&1
> +	[ -f core ] || tst_brk TCONF "missing core file"

TCONF or TBROK that is the question.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence

[Petr Vorel]

> Hi!
> > Maybe this sanity check is useless. WDYT?

> I guess that it does not harm.

Thanks for your review!

> >  testcases/kernel/mem/vma/vma05.sh | 2 ++
> >  1 file changed, 2 insertions(+)

> > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> > index c9e4becdb..30b1d689a 100755
> > --- a/testcases/kernel/mem/vma/vma05.sh
> > +++ b/testcases/kernel/mem/vma/vma05.sh
> > @@ -54,6 +54,8 @@ vma_report_check()

> >  	rm -rf core*
> >  	{ vma05_vdso; } > /dev/null 2>&1
> > +	[ -f core ] || tst_brk TCONF "missing core file"

> TCONF or TBROK that is the question.

I guess TBROK is better in this case. I wonder myself why I type TCONF.
If nobody complains, I'll merge this with TBROK and your ack.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence

[Petr Vorel]

Hi all,

> > Hi!
> > > Maybe this sanity check is useless. WDYT?

> > I guess that it does not harm.

> Thanks for your review!

> > >  testcases/kernel/mem/vma/vma05.sh | 2 ++
> > >  1 file changed, 2 insertions(+)

> > > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> > > index c9e4becdb..30b1d689a 100755
> > > --- a/testcases/kernel/mem/vma/vma05.sh
> > > +++ b/testcases/kernel/mem/vma/vma05.sh
> > > @@ -54,6 +54,8 @@ vma_report_check()

> > >  	rm -rf core*
> > >  	{ vma05_vdso; } > /dev/null 2>&1
> > > +	[ -f core ] || tst_brk TCONF "missing core file"

> > TCONF or TBROK that is the question.

> I guess TBROK is better in this case. I wonder myself why I type TCONF.
> If nobody complains, I'll merge this with TBROK and your ack.

Merged with TBROK, thanks for your time.

Kind regards,
Petr

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp