Re: [LTP] [PATCH] Add simple Containerfile

[Petr Vorel <pvorel@suse.cz>]

Hi Richie,

...
> > The benefit is that you have not only a clean git repo for the container,
> > but also not touching your working copy directory. But unless nobody else
> > raise any concern, I'm ok with your current proposal.

> Ah I think I see your concern now. It does not touch the directory
> outside the container. It copies everything in first (IDK if it actually
> copies the data if you are doing a local build).

Ah, sorry, of course.

> Note that I tried using a .dockerignore to stop build artifacts being
> copied, but it's not as rich as the .gitignore(s) we have sprinkled
> throughout the LTP.

...
> >> >> +#!/bin/sh -eux
> >> > nit: out of curiosity, why -u (fail unset variables and parameters)?

> >> I find it finds errors in shell scripts or when using them. E.g. typo's
> >> in env variable names. I just include it wherever possible.

> > +1, maybe we should add it to the current ci scripts as well (+ use params
> > instead of setting it via set command, it should work in dash and busybox shell
> > as well).

> Yeah, I think it should be the default.

I add it at least to the original scripts in ci directory, it should be safe
here. I'll test tst_test.sh and tst_net.sh and send a patch for this.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp