[LTP] [PATCH] pipe07: close /proc/self/fd after counting fds

Edward Liaw via ltp
2023-09-30T00:00:31Z

Leaving the directory fd open will count against the max number of fds
opened, so the final expected count will be off.

Also, removed the halving / doubling of exp_num_pipes since it is
redundant.

Signed-off-by: Edward Liaw <edliaw@google.com>
---
testcases/kernel/syscalls/pipe/pipe07.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/pipe/pipe07.c b/testcases/kernel/syscalls/pipe/pipe07.c
index 196485684..01f6b78f8 100644
--- a/testcases/kernel/syscalls/pipe/pipe07.c
+++ b/testcases/kernel/syscalls/pipe/pipe07.c
@@ -45,6 +45,8 @@ static int record_open_fds(void)
opened_fds[num_opened_fds++] = fd;
}

+ SAFE_CLOSEDIR(dir);
+
return num_opened_fds;
}

@@ -56,8 +58,8 @@ static void setup(void)
tst_res(TINFO, "getdtablesize() = %d", max_fds);
pipe_fds = SAFE_MALLOC(max_fds * sizeof(int));

- exp_num_pipes = (max_fds - record_open_fds()) / 2;
- tst_res(TINFO, "expected max fds to be opened by pipe(): %d", exp_num_pipes * 2);
+ exp_num_pipes = max_fds - record_open_fds();
+ tst_res(TINFO, "expected max fds to be opened by pipe(): %d", exp_num_pipes);
}

static void run(void)
@@ -73,7 +75,7 @@ static void run(void)
} while (!TST_RET);

TST_EXP_EQ_LI(errno, EMFILE);
- TST_EXP_EQ_LI(exp_num_pipes * 2, num_pipe_fds);
+ TST_EXP_EQ_LI(exp_num_pipes, num_pipe_fds);

for (int i = 0; i < num_pipe_fds; i++)
SAFE_CLOSE(pipe_fds[i]);
--
2.42.0.582.g8ccd20d70d-goog