From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E3CAE95A8E for ; Mon, 9 Oct 2023 08:01:52 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 6A5CD3CD812 for ; Mon, 9 Oct 2023 10:01:50 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id AC3073C896E for ; Mon, 9 Oct 2023 10:01:35 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id DA2441BBB450 for ; Mon, 9 Oct 2023 10:01:34 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E86C61F390; Mon, 9 Oct 2023 08:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696838492; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oUF1KM4ACkOeXrnJnbd6HRq+uHCU1XT/QZiSJs+eEcs=; b=RA9/j4FphVBZ8F9T9hF2bdtlzD8+FF8LbLbtUqPI3OGVUS82vgH+DDD2+eAr4wLGfC+ggu kGoj50SGzRyGsRr794UwYv2zi0rnoP3tAbKsYBIGzh0m9JQyjrAgjBUstKgVDk7dcIAGsF 1x9tZDqNm9efrOFAMGxgUuMcsR9aVjA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696838492; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oUF1KM4ACkOeXrnJnbd6HRq+uHCU1XT/QZiSJs+eEcs=; b=CdmVbfACUX15Nrg+z2PaEGRjI4r7GA8szY3o+ke1F5jjnY//hgVTUY+Hdufhq2ksw+acdX vmNK5+18W/orQEAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C76DD13905; Mon, 9 Oct 2023 08:01:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oiaiLlyzI2WKMwAAMHmgww (envelope-from ); Mon, 09 Oct 2023 08:01:32 +0000 Date: Mon, 9 Oct 2023 10:01:31 +0200 From: Petr Vorel To: Avinesh Kumar Message-ID: <20231009080131.GA370124@pevik> References: <20230921054821.12855-1-akumar@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230921054821.12855-1-akumar@suse.de> X-Virus-Scanned: clamav-milter 1.0.1 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3] syscalls/mmap04: Validate mapping perms in /proc/self/maps X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Avinesh, > Validating the various combinations of prot+flags arguments in mmap() > call and parsing the /proc/self/maps file to verifying resulting mapping > has the permission bits as requested in mmap() call. LGTM + you fixed all Cyril's comments. Reviewed-by: Petr Vorel ... > + if (!strcmp(perms, tc->exp_perms)) > + tst_res(TPASS, "mapping permissions in /proc matched: %s", perms); > + else > + tst_res(TFAIL, "mapping permissions in /proc mismatched," > + " expected: %s, found: %s", > + tc->exp_perms, perms); Very nit: I wouldn't split the string. IMHO it's better to have easier git grepping, than follow 80 line rules. Also checkpatch does not complain on this: else tst_res(TFAIL, "mapping permissions in /proc mismatched, expected: %s, found: %s", tc->exp_perms, perms); This can be fixed before merge. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp