From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] link05: Convert docs to docparse
Date: Thu, 12 Oct 2023 12:08:12 +0200 [thread overview]
Message-ID: <20231012100812.GD618148@pevik> (raw)
In-Reply-To: <1697021709-22916-2-git-send-email-xuyang2018.jy@fujitsu.com>
Hi Xu,
> +++ b/testcases/kernel/syscalls/link/link05.c
> @@ -1,12 +1,14 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
> - * AUTHOR : Richard Logan
> - * CO-PILOT : William Roske
> + * AUTHOR : Richard Logan
> + * CO-PILOT : William Roske
* Authors: Richard Logan, William Roske
> * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
* Copyright (c) Linux Test Project, 2001-2023
> */
With this fixed:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> -/*
> +/*\
> + * [Description]
> + *
> * Test if link(2) fails with EMLINK.
> */
I was thinking how to cleanup test a bit. I don't like the loop
(SAFE_STAT(fname, &fbuf)). It could be simplified with putting
the loop into .tcnt = 1000, if (1000) (and put 1000 to #define).
Also it mixes tabs and spaces (visible in make check-link05,
spaces should be converted to tabs).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-12 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 10:55 [LTP] [PATCH 1/3] link03: Convert docs to docparse Yang Xu
2023-10-11 10:55 ` [LTP] [PATCH 2/3] link05: " Yang Xu
2023-10-12 10:08 ` Petr Vorel [this message]
2023-10-17 6:11 ` Yang Xu (Fujitsu)
2023-10-11 10:55 ` [LTP] [PATCH 3/3] link08: " Yang Xu
2023-10-12 9:58 ` Petr Vorel
2023-10-13 5:49 ` Yang Xu (Fujitsu)
2023-10-12 10:00 ` Petr Vorel
2023-10-13 5:45 ` Yang Xu (Fujitsu)
2023-10-12 9:55 ` [LTP] [PATCH 1/3] link03: " Petr Vorel
2023-10-13 5:43 ` Yang Xu (Fujitsu)
2023-10-13 6:12 ` Petr Vorel
2023-10-25 23:51 ` Petr Vorel
2023-10-26 7:37 ` [LTP] 回复: " Yang Xu (Fujitsu)
2023-10-31 7:22 ` [LTP] " Yang Xu (Fujitsu)
2023-11-03 7:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012100812.GD618148@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox