From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] syscalls/renameat: Remove renameat fallback definition
Date: Mon, 16 Oct 2023 10:03:49 +0200 [thread overview]
Message-ID: <20231016080349.GA844528@pevik> (raw)
In-Reply-To: <1694770587-9502-1-git-send-email-xuyang2018.jy@fujitsu.com>
Hi Xu,
> Looking at man renameat, it was added into kernel 2.6.16 and since the
> oldest kernel we support is 3.10 (see doc/supported-kernel-libc-versions
> .txt) we can as well completely drop this fallback definition.
BTW although man is correct, the lapi function was IMHO done due missing libc
support. It was added in glibc 2.4, thus not sure why the support was added in
2014, probably to support the oldest distros.
Also, without kernel support the function would not work at all,
therefore it is irrelevant when readlinkat was added into kernel.
Thus I dared to update the commit message.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-10-16 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 9:36 [LTP] [PATCH v2] syscalls/renameat: Remove renameat fallback definition Yang Xu
2023-09-21 6:08 ` Petr Vorel
2023-09-21 7:02 ` Yang Xu (Fujitsu)
2023-10-13 10:13 ` Yang Xu (Fujitsu)
2023-10-16 7:38 ` Petr Vorel
2023-10-16 8:03 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016080349.GA844528@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox