Re: [LTP] [RFC PATCH 0/7] Remove scsi testsuite + various testscripts

[Petr Vorel <pvorel@suse.cz>]

Hi Richie, all,

thanks for your review, merged.

> Hello,

> Petr Vorel <pvorel@suse.cz> writes:

> > Hi,

> > cleanup of 2 old scsi testsuites and some of legacy testscripts.
> > IMHO the testsuites are not worth of fixing.

> Very good. My only suggestion is to leave a tombstone in the
> documentation (or github issues) any time we delete something big and
> the thing it was supposed to test still should be tested.

I understand the need of missing coverage, preferably over github issue
(we document missing coverage over github issues already).

I wonder what should be noted in this case. These test scripts attempted to test:
* autofs (run other tests on autofs actually)
* BIO (we still have testcases/kernel/device-drivers/tbio/)
* sysfs (but we have at least some sysfs tests)
* SCSI (I suppose these will be better handled elsewhere - xfstests have
  scsi_debug file, mention scsi in some generic and xfs specific tests)
* device mapper tests (there is something ruby based:
https://github.com/jthornber/device-mapper-test-suite from Joe Thornber from Red
Hat)

> Something like "There was a testsuite called X, it appeared to do
> Y, but we had to remove it because of Z".

> It could be useful when answering questions about test feasability and
> for SEO.

I'm not sure if this 20 years old code deserves this description (but feel free
to write it if you think so). But identifying missing coverage is of course
important. Maybe we could have a special wiki page which would link missing
coverage issues [1], but also highlight the most important ones (big subsystem
missing) and also point out what we consider being tested elsewhere or what
would be hard to test with LTP thus should be tested elsewhere.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/labels/missing%20coverage

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp