From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D7CC25B6B for ; Wed, 25 Oct 2023 22:20:54 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E7C213CF90B for ; Thu, 26 Oct 2023 00:20:52 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E278C3CEC3C for ; Thu, 26 Oct 2023 00:20:42 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 187781400457 for ; Thu, 26 Oct 2023 00:20:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B11A91F459; Wed, 25 Oct 2023 22:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698272440; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VhZHfIoQ7K3QJe8MI4LgSucy/M+gMPscTRSEGlUQ5Oc=; b=2CZ2XsVuV4CYngcJ1yS25HnuxceVCkkuNTscknXjrqfWF6s/K393kW9rykdJf/XdEwpQ9Z vCp+67ubJ7WrSMfYw9o64dU09FGBrMihBkDDyvy9Dde+nOfmepAuVw4LFe+LeE4Tc8FQFL beeweyxdsDGT6ais2pIL/XX48exmk9g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698272440; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VhZHfIoQ7K3QJe8MI4LgSucy/M+gMPscTRSEGlUQ5Oc=; b=v9Oy8id3OaFuzkZvQjLy1urxgVTibBUD/Cc79JAmi3if+Hr5C0iKRORZdr3xhPIGTx2s/j r955vgc8xUiglgDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8DA2C13524; Wed, 25 Oct 2023 22:20:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7e7yILiUOWWnQwAAMHmgww (envelope-from ); Wed, 25 Oct 2023 22:20:40 +0000 Date: Thu, 26 Oct 2023 00:20:39 +0200 From: Petr Vorel To: Marius Kittler , ltp@lists.linux.it Message-ID: <20231025222039.GE477570@pevik> References: <20231025110835.28832-1-mkittler@suse.de> <20231025110835.28832-2-mkittler@suse.de> <20231025220605.GB477570@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231025220605.GB477570@pevik> Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-6.16 / 50.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.86)[99.40%] X-Virus-Scanned: clamav-milter 1.0.1 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v8 1/4] Refactor ioctl02.c to use the new test API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Marius, > There are #if 0 commented code with 2.6.24 comments. I doubt it's useful, please > delete it (the same problem I reported few months ago for your getxattr01.c rewrite). I see you have it in 3rd commit. I would merge squash it into the first one. Martin has also suggested the same in v7. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp