From: Petr Vorel <pvorel@suse.cz>
To: Marius Kittler <mkittler@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v8 2/4] Make checks for termio flags more strict
Date: Thu, 26 Oct 2023 00:31:21 +0200 [thread overview]
Message-ID: <20231025223121.GH477570@pevik> (raw)
In-Reply-To: <20231025110835.28832-3-mkittler@suse.de>
Hi Marius,
...
> - if (!
> - (termio.c_lflag
> - && (ISIG | ICANON | XCASE | ECHO | ECHOE | NOFLSH))) {
> + if (termio.c_lflag != (ISIG | ICANON | XCASE | ECHO | ECHOE
> + | NOFLSH)) {
Shouldn't this be using & ~() ?
if ((termio.c_lflag & ~(ISIG | ICANON | XCASE | ECHO | ECHOE | NOFLSH))) {
Also the other two.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-25 22:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:08 [LTP] [PATCH v8 0/4] Improve ioctl02.c Marius Kittler
2023-10-25 11:08 ` [LTP] [PATCH v8 1/4] Refactor ioctl02.c to use the new test API Marius Kittler
2023-10-25 22:06 ` Petr Vorel
2023-10-25 22:09 ` Petr Vorel
2023-10-25 22:20 ` Petr Vorel
2023-10-25 22:23 ` Petr Vorel
2023-10-25 11:08 ` [LTP] [PATCH v8 2/4] Make checks for termio flags more strict Marius Kittler
2023-10-25 22:31 ` Petr Vorel [this message]
2023-10-25 11:08 ` [LTP] [PATCH v8 3/4] Remove disabled code in ioctl02.c Marius Kittler
2023-10-25 22:22 ` Petr Vorel
2023-10-25 11:08 ` [LTP] [PATCH v8 4/4] Extend ioctl02 to test termio and termios Marius Kittler
2023-10-25 22:13 ` Petr Vorel
2023-10-26 6:34 ` iob via ltp
2023-10-26 8:35 ` Petr Vorel
2023-10-25 21:26 ` [LTP] [PATCH v8 0/4] Improve ioctl02.c Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025223121.GH477570@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mkittler@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox