From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Rick Edgecombe <rick.p.edgecombe@intel.com>,
Pavel Boldin <pboldin@cloudlinux.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] stack_clash: Guard functions used only in 64bit
Date: Thu, 26 Oct 2023 01:14:48 +0200 [thread overview]
Message-ID: <20231025231448.GA510491@pevik> (raw)
In-Reply-To: <ZTjgBkVwwvqgbWm1@rei>
Hi Cyril,
> Hi!
> > To avoid "defined but not used" warnings when compiled on 32bit.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > testcases/cve/stack_clash.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> > diff --git a/testcases/cve/stack_clash.c b/testcases/cve/stack_clash.c
Hi Cyril,
> > +#ifdef __x86_64__
> > static void force_bottom_up(void)
> > {
> > FILE *fh;
> > @@ -134,6 +135,7 @@ static void force_bottom_up(void)
> > out:
> > SAFE_FCLOSE(fh);
> > }
> > +#endif
> Maybe I'm blind but this function does not seem to be called from inside
> of #ifdef __x86_64__.
force_bottom_up() is called only inside do_mmap_placement_test(), which is also
wrapped with #ifdef __x86_64_.
I did not notice that, compiler pointed it out :).
Can I merge with your RBT?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-25 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 8:49 [LTP] [PATCH 1/2] stack_clash: Guard functions used only in 64bit Petr Vorel
2023-10-24 8:49 ` [LTP] [PATCH 2/2] stack_clash: Compile with -Wno-infinite-recursion Petr Vorel
2023-10-25 9:30 ` Cyril Hrubis
2023-10-25 23:15 ` Petr Vorel
2023-10-25 9:29 ` [LTP] [PATCH 1/2] stack_clash: Guard functions used only in 64bit Cyril Hrubis
2023-10-25 23:14 ` Petr Vorel [this message]
2023-10-26 8:43 ` Cyril Hrubis
2023-10-26 9:37 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025231448.GA510491@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pboldin@cloudlinux.com \
--cc=rick.p.edgecombe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox