* [LTP] [PATCH v2 2/4] fchownat: Remove fchownat fallback definition
2023-10-17 6:34 [LTP] [PATCH v2 1/4] readlinkat: Remove readlinkat fallback definition Yang Xu
@ 2023-10-17 6:34 ` Yang Xu
2023-10-17 6:34 ` [LTP] [PATCH v2 3/4] mkdirat: Remove mkdirat " Yang Xu
2023-10-17 6:34 ` [LTP] [PATCH v2 4/4] mknodat: Remove mknodat " Yang Xu
2 siblings, 0 replies; 5+ messages in thread
From: Yang Xu @ 2023-10-17 6:34 UTC (permalink / raw)
To: ltp
According to man chown(2), glibc wrapper for fchownat() was in glibc
2.4 (long time ago, the minimal glibc version we support is 2.17, see
doc/supported-kernel-libc-versions.txt). Therefore removed the fallback.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
configure.ac | 1 -
testcases/kernel/syscalls/fchownat/fchownat.h | 37 -------------------
.../kernel/syscalls/fchownat/fchownat01.c | 1 -
.../kernel/syscalls/fchownat/fchownat02.c | 1 -
4 files changed, 40 deletions(-)
delete mode 100644 testcases/kernel/syscalls/fchownat/fchownat.h
diff --git a/configure.ac b/configure.ac
index 80943bdea..ad216983a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -94,7 +94,6 @@ AC_CHECK_FUNCS_ONCE([ \
execveat \
faccessat2 \
fallocate \
- fchownat \
fsconfig \
fsmount \
fsopen \
diff --git a/testcases/kernel/syscalls/fchownat/fchownat.h b/testcases/kernel/syscalls/fchownat/fchownat.h
deleted file mode 100644
index 927cf929a..000000000
--- a/testcases/kernel/syscalls/fchownat/fchownat.h
+++ /dev/null
@@ -1,37 +0,0 @@
-/*
- * Copyright (c) 2014 Fujitsu Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Library General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
- *
- */
-
-#ifndef FCHOWNAT_H
-#define FCHOWNAT_H
-
-#include <sys/types.h>
-#include "config.h"
-#include "lapi/syscalls.h"
-
-
-#if !defined(HAVE_FCHOWNAT)
-static inline int fchownat(int dirfd, const char *filename, uid_t owner,
- gid_t group, int flags)
-{
- return tst_syscall(__NR_fchownat, dirfd, filename, owner, group, flags);
-}
-#endif
-
-
-#endif /* FCHOWNAT_H */
diff --git a/testcases/kernel/syscalls/fchownat/fchownat01.c b/testcases/kernel/syscalls/fchownat/fchownat01.c
index 3b29f1e75..7771c111a 100644
--- a/testcases/kernel/syscalls/fchownat/fchownat01.c
+++ b/testcases/kernel/syscalls/fchownat/fchownat01.c
@@ -34,7 +34,6 @@
#include "test.h"
#include "safe_macros.h"
-#include "fchownat.h"
#include "lapi/fcntl.h"
#define TESTFILE "testfile"
diff --git a/testcases/kernel/syscalls/fchownat/fchownat02.c b/testcases/kernel/syscalls/fchownat/fchownat02.c
index c39b0a919..6dd1e024e 100644
--- a/testcases/kernel/syscalls/fchownat/fchownat02.c
+++ b/testcases/kernel/syscalls/fchownat/fchownat02.c
@@ -31,7 +31,6 @@
#include <signal.h>
#include "test.h"
#include "safe_macros.h"
-#include "fchownat.h"
#include "lapi/fcntl.h"
#define TESTFILE "testfile"
--
2.39.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* [LTP] [PATCH v2 3/4] mkdirat: Remove mkdirat fallback definition
2023-10-17 6:34 [LTP] [PATCH v2 1/4] readlinkat: Remove readlinkat fallback definition Yang Xu
2023-10-17 6:34 ` [LTP] [PATCH v2 2/4] fchownat: Remove fchownat " Yang Xu
@ 2023-10-17 6:34 ` Yang Xu
2023-10-25 23:45 ` Petr Vorel
2023-10-17 6:34 ` [LTP] [PATCH v2 4/4] mknodat: Remove mknodat " Yang Xu
2 siblings, 1 reply; 5+ messages in thread
From: Yang Xu @ 2023-10-17 6:34 UTC (permalink / raw)
To: ltp
According to man mkdir(2), glibc wrapper for mkdirat() was in glibc
2.4 (long time ago, the minimal glibc version we support is 2.17, see
doc/supported-kernel-libc-versions.txt). Therefore removed the fallback.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
configure.ac | 1 -
include/lapi/mkdirat.h | 20 -------------------
testcases/kernel/syscalls/mkdirat/mkdirat01.c | 1 -
testcases/kernel/syscalls/mkdirat/mkdirat02.c | 1 -
4 files changed, 23 deletions(-)
delete mode 100644 include/lapi/mkdirat.h
diff --git a/configure.ac b/configure.ac
index ad216983a..4cada09ed 100644
--- a/configure.ac
+++ b/configure.ac
@@ -112,7 +112,6 @@ AC_CHECK_FUNCS_ONCE([ \
mallinfo \
mallinfo2 \
mallopt \
- mkdirat \
mknodat \
modify_ldt \
mount_setattr \
diff --git a/include/lapi/mkdirat.h b/include/lapi/mkdirat.h
deleted file mode 100644
index 72eb7f647..000000000
--- a/include/lapi/mkdirat.h
+++ /dev/null
@@ -1,20 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
- */
-
-#ifndef LAPI_MKDIRAT_H__
-#define LAPI_MKDIRAT_H__
-
-#include "config.h"
-#include "lapi/syscalls.h"
-#include "lapi/fcntl.h"
-
-#ifndef HAVE_MKDIRAT
-static inline int mkdirat(int dirfd, const char *dirname, int mode)
-{
- return tst_syscall(__NR_mkdirat, dirfd, dirname, mode);
-}
-#endif
-
-#endif /* LAPI_MKDIRAT_H__ */
diff --git a/testcases/kernel/syscalls/mkdirat/mkdirat01.c b/testcases/kernel/syscalls/mkdirat/mkdirat01.c
index a323ed5b3..ca536bdab 100644
--- a/testcases/kernel/syscalls/mkdirat/mkdirat01.c
+++ b/testcases/kernel/syscalls/mkdirat/mkdirat01.c
@@ -35,7 +35,6 @@
#include <string.h>
#include <signal.h>
#include "test.h"
-#include "lapi/mkdirat.h"
#include "safe_macros.h"
static void setup(void);
diff --git a/testcases/kernel/syscalls/mkdirat/mkdirat02.c b/testcases/kernel/syscalls/mkdirat/mkdirat02.c
index ebc0ed16b..2bd8fe9c0 100644
--- a/testcases/kernel/syscalls/mkdirat/mkdirat02.c
+++ b/testcases/kernel/syscalls/mkdirat/mkdirat02.c
@@ -11,7 +11,6 @@
#define _GNU_SOURCE
#include "tst_test.h"
-#include "lapi/mkdirat.h"
#define MNT_POINT "mntpoint"
#define TEST_DIR "mntpoint/test_dir"
--
2.39.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH v2 3/4] mkdirat: Remove mkdirat fallback definition
2023-10-17 6:34 ` [LTP] [PATCH v2 3/4] mkdirat: Remove mkdirat " Yang Xu
@ 2023-10-25 23:45 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2023-10-25 23:45 UTC (permalink / raw)
To: Yang Xu; +Cc: ltp
Hi Xu,
...
> +++ b/testcases/kernel/syscalls/mkdirat/mkdirat01.c
> @@ -35,7 +35,6 @@
> #include <string.h>
> #include <signal.h>
> #include "test.h"
> -#include "lapi/mkdirat.h"
> #include "safe_macros.h"
...
> +++ b/testcases/kernel/syscalls/mkdirat/mkdirat02.c
> @@ -11,7 +11,6 @@
> #define _GNU_SOURCE
> #include "tst_test.h"
> -#include "lapi/mkdirat.h"
FYI lapi file was also used in lib/tst_cgroup.c and
testcases/network/nfs/nfs_stress/nfs05_make_tree.c. I fixed it before merge.
Whole patchset merged. Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH v2 4/4] mknodat: Remove mknodat fallback definition
2023-10-17 6:34 [LTP] [PATCH v2 1/4] readlinkat: Remove readlinkat fallback definition Yang Xu
2023-10-17 6:34 ` [LTP] [PATCH v2 2/4] fchownat: Remove fchownat " Yang Xu
2023-10-17 6:34 ` [LTP] [PATCH v2 3/4] mkdirat: Remove mkdirat " Yang Xu
@ 2023-10-17 6:34 ` Yang Xu
2 siblings, 0 replies; 5+ messages in thread
From: Yang Xu @ 2023-10-17 6:34 UTC (permalink / raw)
To: ltp
According to man mknod(2), glibc wrapper for mknodat() was in glibc
2.4 (long time ago, the minimal glibc version we support is 2.17, see
doc/supported-kernel-libc-versions.txt). Therefore removed the fallback.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
configure.ac | 1 -
testcases/kernel/syscalls/mknodat/mknodat.h | 35 -------------------
testcases/kernel/syscalls/mknodat/mknodat01.c | 1 -
testcases/kernel/syscalls/mknodat/mknodat02.c | 2 +-
4 files changed, 1 insertion(+), 38 deletions(-)
delete mode 100644 testcases/kernel/syscalls/mknodat/mknodat.h
diff --git a/configure.ac b/configure.ac
index 4cada09ed..ee14504bb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -112,7 +112,6 @@ AC_CHECK_FUNCS_ONCE([ \
mallinfo \
mallinfo2 \
mallopt \
- mknodat \
modify_ldt \
mount_setattr \
move_mount \
diff --git a/testcases/kernel/syscalls/mknodat/mknodat.h b/testcases/kernel/syscalls/mknodat/mknodat.h
deleted file mode 100644
index 8f3a1f007..000000000
--- a/testcases/kernel/syscalls/mknodat/mknodat.h
+++ /dev/null
@@ -1,35 +0,0 @@
-/*
- * Copyright (c) International Business Machines Corp., 2007
- * Copyright (c) 2014 Fujitsu Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Library General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
- *
- */
-
-#ifndef MKNODAT_H
-#define MKNODAT_H
-
-#include <sys/types.h>
-#include "config.h"
-#include "lapi/syscalls.h"
-
-#if !defined(HAVE_MKNODAT)
-int mknodat(int dirfd, const char *filename, mode_t mode, dev_t dev)
-{
- return tst_syscall(__NR_mknodat, dirfd, filename, mode, dev);
-}
-#endif
-
-#endif /* MKNODAT_H */
diff --git a/testcases/kernel/syscalls/mknodat/mknodat01.c b/testcases/kernel/syscalls/mknodat/mknodat01.c
index 6500ca362..3be0a4f87 100644
--- a/testcases/kernel/syscalls/mknodat/mknodat01.c
+++ b/testcases/kernel/syscalls/mknodat/mknodat01.c
@@ -35,7 +35,6 @@
#include "test.h"
#include "safe_macros.h"
#include "lapi/fcntl.h"
-#include "mknodat.h"
#define PATHNAME "mknodattestdir"
diff --git a/testcases/kernel/syscalls/mknodat/mknodat02.c b/testcases/kernel/syscalls/mknodat/mknodat02.c
index eda247fda..fdac5db15 100644
--- a/testcases/kernel/syscalls/mknodat/mknodat02.c
+++ b/testcases/kernel/syscalls/mknodat/mknodat02.c
@@ -37,7 +37,7 @@
#include "test.h"
#include "safe_macros.h"
#include "lapi/fcntl.h"
-#include "mknodat.h"
+#include "lapi/syscalls.h"
static void setup(void);
static void cleanup(void);
--
2.39.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread