From: Petr Vorel <pvorel@suse.cz>
To: "Yang Xu (Fujitsu)" <xuyang2018.jy@fujitsu.com>,
"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/3] link03: Convert docs to docparse
Date: Thu, 26 Oct 2023 01:51:27 +0200 [thread overview]
Message-ID: <20231025235127.GA540370@pevik> (raw)
In-Reply-To: <20231013061217.GA688129@pevik>
Hi Xu,
Also, while you are at it, could you please fix these warnings?
$ make link03
link03.c: In function ‘main’:
link03.c:104:22: warning: ‘%d’ directive writing between 1 and 10 bytes into a region of size between 1 and 255 [-Wformat-overflow=]
104 | sprintf(lname, "%s%d", fname, i);
| ^~
link03.c:104:19: note: directive argument in the range [1, 2147483646]
104 | sprintf(lname, "%s%d", fname, i);
| ^~~~~~
link03.c:104:4: note: ‘sprintf’ output between 2 and 265 bytes into a destination of size 255
104 | sprintf(lname, "%s%d", fname, i);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
link03.c:123:22: warning: ‘%d’ directive writing between 1 and 10 bytes into a region of size between 1 and 255 [-Wformat-overflow=]
123 | sprintf(lname, "%s%d", fname, i);
| ^~
link03.c:123:19: note: directive argument in the range [1, 2147483646]
123 | sprintf(lname, "%s%d", fname, i);
| ^~~~~~
link03.c:123:4: note: ‘sprintf’ output between 2 and 265 bytes into a destination of size 255
123 | sprintf(lname, "%s%d", fname, i);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
link03.c:138:22: warning: ‘%d’ directive writing between 1 and 10 bytes into a region of size between 1 and 255 [-Wformat-overflow=]
138 | sprintf(lname, "%s%d", fname, i);
| ^~
link03.c:138:19: note: directive argument in the range [1, 2147483646]
138 | sprintf(lname, "%s%d", fname, i);
| ^~~~~~
link03.c:138:4: note: ‘sprintf’ output between 2 and 265 bytes into a destination of size 255
138 | sprintf(lname, "%s%d", fname, i);
$ make check-link03
CHECK testcases/kernel/syscalls/link/link03.c
link03.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
link03.c:33: ERROR: do not initialise statics to 0
link03.c:55: ERROR: code indent should use tabs where possible
link03.c:90: ERROR: code indent should use tabs where possible
link03.c:100: ERROR: code indent should use tabs where possible
Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-25 23:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 10:55 [LTP] [PATCH 1/3] link03: Convert docs to docparse Yang Xu
2023-10-11 10:55 ` [LTP] [PATCH 2/3] link05: " Yang Xu
2023-10-12 10:08 ` Petr Vorel
2023-10-17 6:11 ` Yang Xu (Fujitsu)
2023-10-11 10:55 ` [LTP] [PATCH 3/3] link08: " Yang Xu
2023-10-12 9:58 ` Petr Vorel
2023-10-13 5:49 ` Yang Xu (Fujitsu)
2023-10-12 10:00 ` Petr Vorel
2023-10-13 5:45 ` Yang Xu (Fujitsu)
2023-10-12 9:55 ` [LTP] [PATCH 1/3] link03: " Petr Vorel
2023-10-13 5:43 ` Yang Xu (Fujitsu)
2023-10-13 6:12 ` Petr Vorel
2023-10-25 23:51 ` Petr Vorel [this message]
2023-10-26 7:37 ` [LTP] 回复: " Yang Xu (Fujitsu)
2023-10-31 7:22 ` [LTP] " Yang Xu (Fujitsu)
2023-11-03 7:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025235127.GA540370@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox