Re: [LTP] [PATCH] controllers/cpuset: Make mount failure TCONF

[Petr Vorel <pvorel@suse.cz>]

Hi Richie,

> It appears that if the subsystem is available under V2 then mounting
> the V1 can fail. Probably when the V2 has processes assigned to a
> group it controls.

Sounds likely, but it would be good to check this in the kernel code or with
kernel cgroup developers.

> The test should scan the system and find the existing CGroup
> hierarchies and work with those. This can be done by converting the
> test to tst_cgctl or rewriting it in C. It's not clear what the best
> course of action would be.

> For now, this commit just changes the result to TCONF.

+1 (suppose it's the case of already mounted under v2)

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
>  testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index 0cfa0c17e..312654a9d 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -165,7 +165,7 @@ setup()
>  	mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
>  	if [ $? -ne 0 ]; then
>  		cleanup
> -		tst_brkm TFAIL "Could not mount cgroup filesystem with"\
> +		tst_brkm TCONF "Could not mount cgroup filesystem with"\
>  					" cpuset on $CPUSET..Exiting test"

nit: I'd cleanup the message.

		tst_brkm TCONF "Could not mount cgroup filesystem with cpuset on $CPUSET"

Kind regards,
Petr

>  	fi

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp