public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: Stanislav Kholmanskikh <stanislav.kholmanskikh@bell-sw.com>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax
Date: Mon, 30 Oct 2023 15:20:55 +0100	[thread overview]
Message-ID: <20231030142055.GA21733@pevik> (raw)
In-Reply-To: <CAEemH2eUQxxQAh-Ln_hyzu_C_AL36fXsjbKZJqC3rcHsASgQgQ@mail.gmail.com>

> > > > -%_16: CPPFLAGS += -D$(DEF_16)=1

> > Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS?
> > Or the
> > LTP build system it just prepared to the crazy ideas about using C++? :)


> No, I don't think so. I guess you memories it confused with CXXFLAGS :).

> FYI:

> CPPFLAGS (C PreProcessor Flags) are options for the C preprocessor,
> which is the first stage of compilation where macro substitution occurs,
> and conditional compilation directives are processed. These flags are often
> used to specify additional include directories.
>     e.g. CPPFLAGS="-I/some/include/path"

> CFLAGS (C Compiler Flags) are options for the C compiler. These
> flags are often used to specify various compiler settings, such as
> optimization level, warnings level, and debugging information.
>     e.g.  CFLAGS="-O2 -g -Wall"

> CXXFLAGS (C++ Compiler Flags) are options for the C++ compiler.
> It can be used to define options like optimization levels, debugging
> information, warning levels, and more.
>     e.g.  CXXFLAGS="-O2 -g -Wall"

Ah, you're right. Thanks!

> > > Seems we need to keep this one line, otherwise it can't transfer the
> > > 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.

> > Ah, thanks!

> > > The rest looks good to me.
> > > Reviewed-by: Li Wang <liwang@redhat.com>

> > BTW I'm going to push it with you as an author + with your Signed-off-by:
> > tag
> > (you're effectively the autor of the code) and with my RBT.


> Sure, thanks for doing this for me.

Yw.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-10-30 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 17:43 [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax Petr Vorel
2023-10-30  3:29 ` Li Wang
2023-10-30  7:28   ` Petr Vorel
2023-10-30  8:22     ` Li Wang
2023-10-30 14:20       ` Petr Vorel [this message]
2025-03-07 23:45         ` Petr Vorel
2025-03-10  2:40           ` Li Wang
2025-03-11 21:41             ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231030142055.GA21733@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=stanislav.kholmanskikh@bell-sw.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox