From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] Rewrite fsx-linux test
Date: Mon, 13 Nov 2023 17:05:52 +0100 [thread overview]
Message-ID: <20231113160552.GA2235190@pevik> (raw)
In-Reply-To: <20231030110107.4528-2-andrea.cervesato@suse.de>
Hi Andrea,
...
> +++ b/testcases/kernel/fs/fsx-linux/Makefile
> @@ -22,13 +22,11 @@
> top_srcdir ?= ../../../..
> -include $(top_srcdir)/include/mk/env_pre.mk
> +include $(top_srcdir)/include/mk/testcases.mk
> CPPFLAGS += -DNO_XFS -I$(abs_srcdir) \
> -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
> WCFLAGS += -w
> -INSTALL_TARGETS := fsxtest*
> -
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
This could be a separate change, right? The point of separating changes is to
make each patchset smaller, which I agree does not help much here.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-11-13 16:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 11:01 [LTP] [PATCH v2 0/2] Rewrite fsx-linux Andrea Cervesato
2023-10-30 11:01 ` [LTP] [PATCH v2 1/2] Rewrite fsx-linux test Andrea Cervesato
2023-11-01 10:34 ` Petr Vorel
2023-11-01 10:53 ` Cyril Hrubis
2023-11-01 11:11 ` Petr Vorel
2023-11-20 15:55 ` Andrea Cervesato via ltp
2023-11-20 16:50 ` Petr Vorel
2023-11-20 18:24 ` Andrea Cervesato via ltp
2023-11-13 16:05 ` Petr Vorel [this message]
2023-11-14 10:31 ` Andrea Cervesato via ltp
2023-10-30 11:01 ` [LTP] [PATCH v2 2/2] Remove fsx runtest suite Andrea Cervesato
2023-11-13 15:56 ` Petr Vorel
2023-11-13 16:02 ` Petr Vorel
2023-11-28 18:26 ` Petr Vorel
2023-11-29 9:42 ` Andrea Cervesato via ltp
2023-11-13 15:57 ` [LTP] [PATCH v2 0/2] Rewrite fsx-linux Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113160552.GA2235190@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox