[LTP] [PATCH] fanotify14: Revert broken flag support check

[LTP] [PATCH] fanotify14: Revert broken flag support check

[Martin Doucha]

Reverts part of 35f77e75 which obviously doesn't belong in a memcontrol
test patch.

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
 testcases/kernel/syscalls/fanotify/fanotify14.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/fanotify/fanotify14.c b/testcases/kernel/syscalls/fanotify/fanotify14.c
index 908a6638a..0bb789188 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify14.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify14.c
@@ -246,8 +246,7 @@ static void do_test(unsigned int number)
 	tst_res(TINFO, "Test case %d: fanotify_init(%s, O_RDONLY)", number,
 		tc->init.desc);
 
-	//if (tc->init.flags & ~supported_init_flags) {
-	if (tc->init.flags == supported_init_flags) {
+	if (tc->init.flags & ~supported_init_flags) {
 		tst_res(TCONF, "Unsupported init flags");
 		return;
 	}
-- 
2.42.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] fanotify14: Revert broken flag support check

[Marius Kittler]

Hi,
that change was definitely not part of the memcontrol-related patch I sent to 
this mailinglist.

I think this change was part of another patchset I sent to the list. However, 
this patchset definitely didn't contain out-commented code so someone was 
editing it before pushing. When I remember correctly, I only changed the flags 
as it was suggested to me as a review comment (and I personally wouldn't have 
done this change in the first place).

So I'm fine with reverting the change.

Reviewed-by: Marius Kittler <mkittler@suse.de>




-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] fanotify14: Revert broken flag support check

[Amir Goldstein]

[cc Petr]

On Wed, Nov 15, 2023 at 12:41 PM Martin Doucha <mdoucha@suse.cz> wrote:
>
> Reverts part of 35f77e75 which obviously doesn't belong in a memcontrol
> test patch.
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
>  testcases/kernel/syscalls/fanotify/fanotify14.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify14.c b/testcases/kernel/syscalls/fanotify/fanotify14.c
> index 908a6638a..0bb789188 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify14.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify14.c
> @@ -246,8 +246,7 @@ static void do_test(unsigned int number)
>         tst_res(TINFO, "Test case %d: fanotify_init(%s, O_RDONLY)", number,
>                 tc->init.desc);
>
> -       //if (tc->init.flags & ~supported_init_flags) {
> -       if (tc->init.flags == supported_init_flags) {
> +       if (tc->init.flags & ~supported_init_flags) {
>                 tst_res(TCONF, "Unsupported init flags");
>                 return;
>         }
> --
> 2.42.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] fanotify14: Revert broken flag support check

[Petr Vorel]

Hi all,

> [cc Petr]
Amir, thanks for ping me.

> On Wed, Nov 15, 2023 at 12:41 PM Martin Doucha <mdoucha@suse.cz> wrote:

> > Reverts part of 35f77e75 which obviously doesn't belong in a memcontrol
> > test patch.
I'm very sorry, my fault. Merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp