From: Petr Vorel <pvorel@suse.cz>
To: Marius Kittler <mkittler@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 0/1] *** Extend ioctl02 to test termio and termios ***
Date: Tue, 28 Nov 2023 14:29:38 +0100 [thread overview]
Message-ID: <20231128132938.GE381183@pevik> (raw)
In-Reply-To: <20231114150922.28652-1-mkittler@suse.de>
Hi Marius,
> This is the same as v2 except that the variable assignments have been
> moved out of the macros as this is apparently "frowned upon" :-)
This was Cyril's request. Am I blind, the diff is the same, compared patches,
mboxes, I don't see this change.
Also, for single patch is better not include cover letter (the discussion is
then on 2 places, there is then not obvious in patchwork why patch was set
"changes requested").
Kind regards,
Petr
> Marius Kittler (1):
> Extend ioctl02 to test termio and termios
> testcases/kernel/syscalls/ioctl/ioctl02.c | 191 +++++++++++++---------
> 1 file changed, 118 insertions(+), 73 deletions(-)
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-11-28 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 15:09 [LTP] [PATCH v3 0/1] *** Extend ioctl02 to test termio and termios *** Marius Kittler
2023-11-14 15:09 ` [LTP] [PATCH v3 1/1] Extend ioctl02 to test termio and termios Marius Kittler
2023-12-01 18:48 ` Petr Vorel
2023-11-28 13:29 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128132938.GE381183@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mkittler@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox