Re: [LTP] [PATCH v1] rwtest: Confirm df is a symlink to busybox

[Petr Vorel <pvorel@suse.cz>]

Hi Mengchi,

> /bin/df can be a symlink to coreutils. It returns correct info with dir
> arguments.
> Just checking if df is a symlink will include such cases. Need to make
> sure it is linking to busybox before ignoring options.

> Signed-off-by: Mengchi Cheng <mengcc@amazon.com>
> ---
>  testcases/kernel/fs/doio/rwtest | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

> diff --git a/testcases/kernel/fs/doio/rwtest b/testcases/kernel/fs/doio/rwtest
> index 6725e1426..26659e9d3 100644
> --- a/testcases/kernel/fs/doio/rwtest
> +++ b/testcases/kernel/fs/doio/rwtest
> @@ -329,10 +329,10 @@ do
>  		else
>  			# If df is a symlink (to busybox) then do not pass the $dir and $dfOpts
>  			# parameters because they don't work as expected
> -                        if test -h $(which df)
> -                           then
> -                               dir=""; dfOpts="";
> -                        fi
> +			if [[ "$(readlink -f "$(which df)")" == *"busybox"* ]]
Could you please test if this works?

			if [ "$(readlink -f "$(which df)")" = "busybox" ]

Although this script uses bash, we generally don't want to use it. Thus it'd be
better to not introduce any bash specific code.

BTW this is very old and very ugly script, we should cleanup it or delete:
https://github.com/linux-test-project/ltp/issues/1110

Kind regards,
Petr

> +			then
> +				dir=""; dfOpts="";
> +			fi

>  			blks=$(df $dfOpts $dir |
>  			(while read fs blks used avail cap mountpoint

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp