From: Mengchi Cheng via ltp <ltp@lists.linux.it>
To: <ltp@lists.linux.it>
Cc: Mengchi Cheng <mengcc@amazon.com>
Subject: [LTP] [PATCH v2] rwtest: Remove df symlink check
Date: Fri, 1 Dec 2023 19:25:52 -0800 [thread overview]
Message-ID: <20231202032552.1142294-1-mengcc@amazon.com> (raw)
busybox has -P option since 2008. df symlink works fine with
directory options in later versions. The check is not necessary.
Signed-off-by: Mengchi Cheng <mengcc@amazon.com>
---
testcases/kernel/fs/doio/rwtest | 6 ------
1 file changed, 6 deletions(-)
diff --git a/testcases/kernel/fs/doio/rwtest b/testcases/kernel/fs/doio/rwtest
index 6725e1426..f15ce17e6 100644
--- a/testcases/kernel/fs/doio/rwtest
+++ b/testcases/kernel/fs/doio/rwtest
@@ -327,12 +327,6 @@ do
then
blks=${szblks[$n]}
else
- # If df is a symlink (to busybox) then do not pass the $dir and $dfOpts
- # parameters because they don't work as expected
- if test -h $(which df)
- then
- dir=""; dfOpts="";
- fi
blks=$(df $dfOpts $dir |
(while read fs blks used avail cap mountpoint
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-12-02 3:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 3:25 Mengchi Cheng via ltp [this message]
2023-12-03 14:56 ` [LTP] [PATCH v2] rwtest: Remove df symlink check Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231202032552.1142294-1-mengcc@amazon.com \
--to=ltp@lists.linux.it \
--cc=mengcc@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox