* [LTP] [PATCH v2] rwtest: Remove df symlink check
@ 2023-12-02 3:25 Mengchi Cheng via ltp
2023-12-03 14:56 ` Petr Vorel
0 siblings, 1 reply; 2+ messages in thread
From: Mengchi Cheng via ltp @ 2023-12-02 3:25 UTC (permalink / raw)
To: ltp; +Cc: Mengchi Cheng
busybox has -P option since 2008. df symlink works fine with
directory options in later versions. The check is not necessary.
Signed-off-by: Mengchi Cheng <mengcc@amazon.com>
---
testcases/kernel/fs/doio/rwtest | 6 ------
1 file changed, 6 deletions(-)
diff --git a/testcases/kernel/fs/doio/rwtest b/testcases/kernel/fs/doio/rwtest
index 6725e1426..f15ce17e6 100644
--- a/testcases/kernel/fs/doio/rwtest
+++ b/testcases/kernel/fs/doio/rwtest
@@ -327,12 +327,6 @@ do
then
blks=${szblks[$n]}
else
- # If df is a symlink (to busybox) then do not pass the $dir and $dfOpts
- # parameters because they don't work as expected
- if test -h $(which df)
- then
- dir=""; dfOpts="";
- fi
blks=$(df $dfOpts $dir |
(while read fs blks used avail cap mountpoint
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [LTP] [PATCH v2] rwtest: Remove df symlink check
2023-12-02 3:25 [LTP] [PATCH v2] rwtest: Remove df symlink check Mengchi Cheng via ltp
@ 2023-12-03 14:56 ` Petr Vorel
0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2023-12-03 14:56 UTC (permalink / raw)
To: Mengchi Cheng; +Cc: ltp
Hi Mengchi,
merged, thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-03 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-02 3:25 [LTP] [PATCH v2] rwtest: Remove df symlink check Mengchi Cheng via ltp
2023-12-03 14:56 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox