public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/3] lib/tests: Add test for testing tst_res() flags
Date: Thu, 14 Dec 2023 13:19:35 +0100	[thread overview]
Message-ID: <20231214121935.GA800332@pevik> (raw)
In-Reply-To: <ZXrGTkJIh4YluH3T@rei>

> Hi!
> > > Maybe it would make sense the loop over the flags here instead, so that
> > > we don't have to produce second TPASS message.

> > I'm not sure if I follow you. I wanted to use the flag in tst_res(),
> > but for these two there would be tst_brk(TBROK) due missing result.

> I mean that if we put TBROK last in the array we can do:

> 	for (i = 0; i < ARRAY_SIZE(...); i++)
> 		tst_res(....);

Yeah, I realized that later (it was too late already when I wrote the question).
My motivation was that extra TPASS also test functionality, we test, that TINFO
and TDEBUG are not results. But this is probably not important, thus I'll just
loop over array. And sure, I'll put TBROK to the end.

Kind regards,
Petr

> I.e. loop over all the flags in a single call of the function, which
> would mean that we do not have to add artificial TPASS at the end.


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-12-14 12:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 16:18 [LTP] [PATCH v3 0/3] Add TDEBUG tst_res() flag Petr Vorel
2023-12-11 16:18 ` [LTP] [PATCH v3 1/3] lib/tests: Add test for testing tst_res() flags Petr Vorel
2023-12-13 19:04   ` Cyril Hrubis
2023-12-13 23:40     ` Petr Vorel
2023-12-14  9:09       ` Cyril Hrubis
2023-12-14 12:19         ` Petr Vorel [this message]
2023-12-14 12:26           ` Petr Vorel
2023-12-11 16:18 ` [LTP] [PATCH v3 2/3] lib: Add support for TDEBUG tst_res() flag Petr Vorel
2023-12-13 19:15   ` Cyril Hrubis
2023-12-13 23:11     ` Petr Vorel
2023-12-14  9:41       ` Cyril Hrubis
2023-12-14 12:08         ` Petr Vorel
2023-12-13 23:48     ` Petr Vorel
2023-12-14  9:39       ` Cyril Hrubis
2023-12-11 16:18 ` [LTP] [PATCH v3 3/3] fsx-linux: Reduce log output with TDEBUG Petr Vorel
2023-12-12 10:08   ` Andrea Cervesato via ltp
2023-12-13 19:18     ` Cyril Hrubis
2023-12-11 16:27 ` [LTP] [PATCH v3 0/3] Add TDEBUG tst_res() flag Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231214121935.GA800332@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox