Re: [LTP] [PATCH v1] getcwd01: Implement .test_variants

[Petr Vorel <pvorel@suse.cz>]

Hi Wei,

>  /*
>   * DESCRIPTION
> - * Testcase to test that getcwd(2) sets errno correctly.
> - * 1) getcwd(2) fails if buf points to a bad address.
> - * 2) getcwd(2) fails if the size is invalid.
> - * 3) getcwd(2) fails if the size is set to 0.
> - * 4) getcwd(2) fails if the size is set to 1.
> - * 5) getcwd(2) fails if buf points to NULL and the size is set to 1.
> - *
> - * Expected Result:
> - * 1) getcwd(2) should return NULL and set errno to EFAULT.
> - * 2) getcwd(2) should return NULL and set errno to EFAULT.
> - * 3) getcwd(2) should return NULL and set errno to ERANGE.
> - * 4) getcwd(2) should return NULL and set errno to ERANGE.
> - * 5) getcwd(2) should return NULL and set errno to ERANGE.
> + * Testcase to test that getcwd() sets errno correctly.

We prefer to keep info about tested errno (you can write errno or errnos if they
are different for syscall into it).

* 1) getcwd(2) fails if buf points to a bad address (EFAULT)
* 2) getcwd(2) fails if the size is invalid (ERANGE)

>  #include <errno.h>
> @@ -27,28 +16,68 @@
>  #include "lapi/syscalls.h"

>  static char buffer[5];
> -
> -static struct t_case {
> +struct getcwd_variants {
> +	void (*getcwd)(char *buf, size_t size, int exp_err);
>  	char *buf;
>  	size_t size;
>  	int exp_err;
> -} tcases[] = {
> -	{(void *)-1, PATH_MAX, EFAULT},
> -	{NULL, (size_t)-1, EFAULT},
> -	{buffer, 0, ERANGE},
> -	{buffer, 1, ERANGE},
> -	{NULL, 1, ERANGE}
>  };

> +static void verify_getcwd_raw_syscall(char *buf, size_t size, int exp_err);
> +static void verify_getcwd(char *buf, size_t size, int exp_err);
> +
> +static struct getcwd_variants variants[] = {
> +#ifdef __GLIBC__
> +	{ .getcwd = verify_getcwd, .buf = NULL, .size = (size_t)-1, .exp_err = ENOMEM},
> +	{ .getcwd = verify_getcwd, .buf = NULL, .size = 1, .exp_err = ERANGE},
> +#endif
> +	{ .getcwd = verify_getcwd, .buf = (void *)-1, .size = PATH_MAX, .exp_err = EFAULT},
> +	{ .getcwd = verify_getcwd, .buf = buffer, .size = 0, .exp_err = EINVAL},
> +	{ .getcwd = verify_getcwd, .buf = buffer, .size = 1, .exp_err = ERANGE},
> +	{ .getcwd = verify_getcwd_raw_syscall, .buf = buffer, .size = 0, .exp_err = ERANGE},
> +	{ .getcwd = verify_getcwd_raw_syscall, .buf = (void *)-1, .size = PATH_MAX, .exp_err = EFAULT},
> +	{ .getcwd = verify_getcwd_raw_syscall, .buf = NULL, .size = (size_t)-1, .exp_err = EFAULT},
> +	{ .getcwd = verify_getcwd_raw_syscall, .buf = buffer, .size = 0, .exp_err = ERANGE},
> +	{ .getcwd = verify_getcwd_raw_syscall, .buf = buffer, .size = 1, .exp_err = ERANGE},
> +	{ .getcwd = verify_getcwd_raw_syscall, .buf = NULL, .size = 1, .exp_err = ERANGE},

Well, this is works, but we don't use test variants this way. We define
.test_variants in struct tst_test. Please have look how getdents01.c for
example.

Why it's important (besides consistency of how we write tests)? We parse
test_variants in our documentation.
https://github.com/linux-test-project/ltp/releases/download/20230929/metadata.20230929.html
=> see metadata.html#test_variants in your locally downloaded file, or run:
cd metadata && make && chromium ../docparse/*.html

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp