[LTP] [PATCH 0/3] More fsx-linux fixes

public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed

* [LTP] [PATCH 0/3] More fsx-linux fixes
@ 2023-12-15 18:31 Petr Vorel
  2023-12-15 18:31 ` [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60 Petr Vorel
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Petr Vorel @ 2023-12-15 18:31 UTC (permalink / raw)
  To: ltp

besides my patchset, which reduces logging via TDEBUG [1] there is
another fix for timeout and runtest cleanup.

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/list/?series=386694&state=*

Petr Vorel (3):
  fsx-linux: Add .max_runtime = 60
  runtest/ltp-aiodio.part3: Keep only unique records
  runtest/ltp-aiodio.part3: Renumber tests

 runtest/ltp-aiodio.part3                  | 69 +++++++----------------
 testcases/kernel/fs/fsx-linux/fsx-linux.c |  1 +
 2 files changed, 22 insertions(+), 48 deletions(-)

-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60
  2023-12-15 18:31 [LTP] [PATCH 0/3] More fsx-linux fixes Petr Vorel
@ 2023-12-15 18:31 ` Petr Vorel
  2023-12-18  7:47   ` Li Wang
  2023-12-15 18:31 ` [LTP] [PATCH 2/3] runtest/ltp-aiodio.part3: Keep only unique records Petr Vorel
  2023-12-15 18:31 ` [LTP] [PATCH 3/3] runtest/ltp-aiodio.part3: Renumber tests Petr Vorel
  2 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2023-12-15 18:31 UTC (permalink / raw)
  To: ltp

From: Petr Vorel <petr.vorel@gmail.com>

fsx-linux has entry in the runtest file, where it runs quite long via
-N 100000 (number of operations). While this is ok on normal worker
(runs ~20s), it timeouts on slightly overbooked SUT.

On heavily overbooked SUT it will still require LTP_TIMEOUT_MUL or
LTP_RUNTIME_MUL, but that's expected.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/fs/fsx-linux/fsx-linux.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/fs/fsx-linux/fsx-linux.c b/testcases/kernel/fs/fsx-linux/fsx-linux.c
index 658fc99c3..32fc70e01 100644
--- a/testcases/kernel/fs/fsx-linux/fsx-linux.c
+++ b/testcases/kernel/fs/fsx-linux/fsx-linux.c
@@ -367,6 +367,7 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = cleanup,
 	.test_all = run,
+	.max_runtime = 60,
 	.options = (struct tst_option[]) {
 		{ "l:", &str_file_max_size, "Maximum size in MB of the test file(s) (default 262144)" },
 		{ "o:", &str_op_max_size, "Maximum size for single operation (default 65536)" },
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60
  2023-12-15 18:31 ` [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60 Petr Vorel
@ 2023-12-18  7:47   ` Li Wang
  2023-12-18 12:31     ` Petr Vorel
  0 siblings, 1 reply; 6+ messages in thread
From: Li Wang @ 2023-12-18  7:47 UTC (permalink / raw)
  To: Petr Vorel; +Cc: ltp

For patch set:
Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60
  2023-12-18  7:47   ` Li Wang
@ 2023-12-18 12:31     ` Petr Vorel
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2023-12-18 12:31 UTC (permalink / raw)
  To: Li Wang; +Cc: ltp

Hi Li, all,

thanks a lot, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 2/3] runtest/ltp-aiodio.part3: Keep only unique records
  2023-12-15 18:31 [LTP] [PATCH 0/3] More fsx-linux fixes Petr Vorel
  2023-12-15 18:31 ` [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60 Petr Vorel
@ 2023-12-15 18:31 ` Petr Vorel
  2023-12-15 18:31 ` [LTP] [PATCH 3/3] runtest/ltp-aiodio.part3: Renumber tests Petr Vorel
  2 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2023-12-15 18:31 UTC (permalink / raw)
  To: ltp

When ltp-aiodio.part3 was added in f5fb66199, it contained & to run
some of the tests in paralel. It might never worked as expected (it was
removed in 7df75e26a, added again in 01bca9a82 and finally removed in
2a61af975).

But now, after fsx-linux rewrite in 134b08362 there is no
reason to repeat tests (tests in runtests run sequentially),
thus do a final cleanup.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 runtest/ltp-aiodio.part3 | 45 ++++++++--------------------------------
 1 file changed, 9 insertions(+), 36 deletions(-)

diff --git a/runtest/ltp-aiodio.part3 b/runtest/ltp-aiodio.part3
index 65931ddf4..2389e7d64 100644
--- a/runtest/ltp-aiodio.part3
+++ b/runtest/ltp-aiodio.part3
@@ -2,10 +2,6 @@ FSX032 fsx-linux -l 500000 -r 4096 -t 4096 -w 4096 -N 10000
 FSX033 fsx-linux -l 500000 -r 4096 -t 2048 -w 2048 -N 10000
 FSX034 fsx-linux -l 500000 -r 4096 -N 10000
 FSX035 fsx-linux -N 10000
-FSX036 fsx-linux -N 10000
-FSX037 fsx-linux -N 10000
-FSX038 fsx-linux -N 10000
-FSX039 fsx-linux -N 10000
 FSX040 fsx-linux -N 10000 -o 1024
 FSX041 fsx-linux -N 10000 -o 2048
 FSX042 fsx-linux -N 10000 -o 4096
@@ -13,36 +9,13 @@ FSX043 fsx-linux -N 10000 -o 8192
 FSX044 fsx-linux -N 10000 -o 16384
 FSX045 fsx-linux -N 10000 -o 32768
 FSX046 fsx-linux -N 10000 -o 128000
-FSX047 fsx-linux -N 10000 -o 1024
-FSX048 fsx-linux -N 10000 -o 2048
-FSX049 fsx-linux -N 10000 -o 4096
-FSX050 fsx-linux -N 10000 -o 8192
-FSX051 fsx-linux -N 10000 -o 16384
-FSX052 fsx-linux -N 10000 -o 32768
-FSX053 fsx-linux -N 10000 -o 128000
-FSX054 fsx-linux -N 10000  -o 1024 -l 500000 -r 4096 -t 4096 -w 4096
-FSX055 fsx-linux -N 10000  -o 2048 -l 500000 -r 4096 -t 2048 -w 2048
-FSX056 fsx-linux -N 10000  -o 4096 -l 500000 -r 4096 -t 4096 -w 4096
-FSX057 fsx-linux -N 10000  -o 8192 -l 500000 -r 4096 -t 2048 -w 2048
-FSX058 fsx-linux -N 10000  -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
-FSX059 fsx-linux -N 10000  -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
-FSX060 fsx-linux -N 10000  -o 128000 -l 500000 -r 4096 -t 4096 -w 4096
-FSX061 fsx-linux -N 10000 -o 32768
-FSX062 fsx-linux -N 10000 -o 128000
-FSX063 fsx-linux -N 10000  -o 1024  -l 500000 -r 4096 -t 4096 -w 4096
-FSX064 fsx-linux -N 10000  -o 2048 -l 500000 -r 4096 -t 2048 -w 2048
-FSX065 fsx-linux -N 10000  -o 4096 -l 500000 -r 4096 -t 4096 -w 4096
-FSX066 fsx-linux -N 10000  -o 8192  -l 500000 -r 4096 -t 2048 -w 2048
-FSX067 fsx-linux -N 10000  -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
-FSX068 fsx-linux -N 10000  -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
-FSX069 fsx-linux -N 10000  -o 128000 -l 500000 -r 4096 -t 4096 -w 4096
-FSX070 fsx-linux -N 10000  -o 128000 -l 500000 -r 4096 -t 4096 -w 4096
-FSX071 fsx-linux -N 10000  -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
-FSX072 fsx-linux -N 10000  -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
-FSX073 fsx-linux -N 10000  -o 128000 -l 500000 -r 4096 -t 4096 -w 40963
-FSX074 fsx-linux -N 10000  -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
-FSX075 fsx-linux -N 10000  -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
-FSX076 fsx-linux -N 10000  -o 128000 -l 500000 -r 4096 -t 4096 -w 40966
-FSX077 fsx-linux -N 10000
+FSX054 fsx-linux -N 10000 -o 1024 -l 500000 -r 4096 -t 4096 -w 4096
+FSX055 fsx-linux -N 10000 -o 2048 -l 500000 -r 4096 -t 2048 -w 2048
+FSX056 fsx-linux -N 10000 -o 4096 -l 500000 -r 4096 -t 4096 -w 4096
+FSX057 fsx-linux -N 10000 -o 8192 -l 500000 -r 4096 -t 2048 -w 2048
+FSX058 fsx-linux -N 10000 -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
+FSX059 fsx-linux -N 10000 -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
+FSX060 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 4096
+FSX073 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 40963
+FSX076 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 40966
 FSX078 fsx-linux -N 100000
-FSX079 fsx-linux -N 100000
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 3/3] runtest/ltp-aiodio.part3: Renumber tests
  2023-12-15 18:31 [LTP] [PATCH 0/3] More fsx-linux fixes Petr Vorel
  2023-12-15 18:31 ` [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60 Petr Vorel
  2023-12-15 18:31 ` [LTP] [PATCH 2/3] runtest/ltp-aiodio.part3: Keep only unique records Petr Vorel
@ 2023-12-15 18:31 ` Petr Vorel
  2 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2023-12-15 18:31 UTC (permalink / raw)
  To: ltp

Renumber tests to remove gabs. Use lower case to make it obvious it's a
different test from the old scheme.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 runtest/ltp-aiodio.part3 | 42 ++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/runtest/ltp-aiodio.part3 b/runtest/ltp-aiodio.part3
index 2389e7d64..decf2f6ea 100644
--- a/runtest/ltp-aiodio.part3
+++ b/runtest/ltp-aiodio.part3
@@ -1,21 +1,21 @@
-FSX032 fsx-linux -l 500000 -r 4096 -t 4096 -w 4096 -N 10000
-FSX033 fsx-linux -l 500000 -r 4096 -t 2048 -w 2048 -N 10000
-FSX034 fsx-linux -l 500000 -r 4096 -N 10000
-FSX035 fsx-linux -N 10000
-FSX040 fsx-linux -N 10000 -o 1024
-FSX041 fsx-linux -N 10000 -o 2048
-FSX042 fsx-linux -N 10000 -o 4096
-FSX043 fsx-linux -N 10000 -o 8192
-FSX044 fsx-linux -N 10000 -o 16384
-FSX045 fsx-linux -N 10000 -o 32768
-FSX046 fsx-linux -N 10000 -o 128000
-FSX054 fsx-linux -N 10000 -o 1024 -l 500000 -r 4096 -t 4096 -w 4096
-FSX055 fsx-linux -N 10000 -o 2048 -l 500000 -r 4096 -t 2048 -w 2048
-FSX056 fsx-linux -N 10000 -o 4096 -l 500000 -r 4096 -t 4096 -w 4096
-FSX057 fsx-linux -N 10000 -o 8192 -l 500000 -r 4096 -t 2048 -w 2048
-FSX058 fsx-linux -N 10000 -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
-FSX059 fsx-linux -N 10000 -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
-FSX060 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 4096
-FSX073 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 40963
-FSX076 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 40966
-FSX078 fsx-linux -N 100000
+fsx01 fsx-linux -l 500000 -r 4096 -t 4096 -w 4096 -N 10000
+fsx02 fsx-linux -l 500000 -r 4096 -t 2048 -w 2048 -N 10000
+fsx03 fsx-linux -l 500000 -r 4096 -N 10000
+fsx04 fsx-linux -N 10000
+fsx05 fsx-linux -N 10000 -o 1024
+fsx06 fsx-linux -N 10000 -o 2048
+fsx07 fsx-linux -N 10000 -o 4096
+fsx08 fsx-linux -N 10000 -o 8192
+fsx09 fsx-linux -N 10000 -o 16384
+fsx10 fsx-linux -N 10000 -o 32768
+fsx12 fsx-linux -N 10000 -o 128000
+fsx13 fsx-linux -N 10000 -o 1024 -l 500000 -r 4096 -t 4096 -w 4096
+fsx14 fsx-linux -N 10000 -o 2048 -l 500000 -r 4096 -t 2048 -w 2048
+fsx15 fsx-linux -N 10000 -o 4096 -l 500000 -r 4096 -t 4096 -w 4096
+fsx16 fsx-linux -N 10000 -o 8192 -l 500000 -r 4096 -t 2048 -w 2048
+fsx17 fsx-linux -N 10000 -o 16384 -l 500000 -r 4096 -t 4096 -w 4096
+fsx18 fsx-linux -N 10000 -o 32768 -l 500000 -r 4096 -t 2048 -w 2048
+fsx19 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 4096
+fsx20 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 40963
+fsx21 fsx-linux -N 10000 -o 128000 -l 500000 -r 4096 -t 4096 -w 40966
+fsx22 fsx-linux -N 100000
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-12-18 12:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-15 18:31 [LTP] [PATCH 0/3] More fsx-linux fixes Petr Vorel
2023-12-15 18:31 ` [LTP] [PATCH 1/3] fsx-linux: Add .max_runtime = 60 Petr Vorel
2023-12-18  7:47   ` Li Wang
2023-12-18 12:31     ` Petr Vorel
2023-12-15 18:31 ` [LTP] [PATCH 2/3] runtest/ltp-aiodio.part3: Keep only unique records Petr Vorel
2023-12-15 18:31 ` [LTP] [PATCH 3/3] runtest/ltp-aiodio.part3: Renumber tests Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox