From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: pvorel <pvorel@suse.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Delete fork09 test
Date: Wed, 20 Dec 2023 13:29:03 +0100 [thread overview]
Message-ID: <20231220122903.GA393099@pevik> (raw)
In-Reply-To: <CAEemH2e3rshuygLTq5LcK69ONnMAGO+Mcy_FkZJVS4OCHHf5ZQ@mail.gmail.com>
> On Tue, Dec 19, 2023 at 10:55 PM pvorel <pvorel@suse.de> wrote:
> > Hi all,
> > On 2023-11-28 13:56, Petr Vorel wrote:
> > > Hi Andrea,
> > >> From: Andrea Cervesato <andrea.cervesato@suse.com>
> > >> The fork09 test is actually testing what fork10 is already testing:
> > >> accessing an open child's file from parent. For this reason, we delete
> > >> it and let fork10 doing its job.
> > > in fork09 parent opens maximum number of files, child closes one and
> > > attempts to
> > > open another. That is not exactly the same, but it's very similar.
> > > I'm not sure if the scenario would really tests different code path in
> > > kernel/libc or not and we can happily delete it.
> > > Cyril, WDYT?
> > @Li, WDYT?
> Petr, I think you're right, they're not the same test.
> In fork10 parent tries to verify the contents of the file that reset the
> file offset pointer by child.
> But for09 is a bounder test to verify if the child can open one more file
> when 'fd' number approaches (OpenMax-1).
Thank you! Closing this as rejected, Andrea feel free to rewrite the test as
well.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-12-20 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 15:42 [LTP] [PATCH v1] Delete fork09 test Andrea Cervesato
2023-11-28 12:56 ` Petr Vorel
2023-12-19 14:48 ` pvorel
2023-12-20 10:40 ` Li Wang
2023-12-20 12:29 ` Petr Vorel [this message]
2024-03-12 15:19 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220122903.GA393099@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox