From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] mem/lib: remove NH_CPUS flag from get_allowed_nodes_arr
Date: Wed, 20 Mar 2019 08:11:19 -0400 (EDT) [thread overview]
Message-ID: <2023246752.10528425.1553083879724.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2cGPCGOSAmPKrvH3NAx0ujhmO5+-oNCZbCUhA6Q7q7Z6g@mail.gmail.com>
----- Original Message -----
> ping~
>
> On Fri, Feb 22, 2019 at 3:11 PM Li Wang < liwang@redhat.com > wrote:
>
>
> A new BROK was occurred on a special numa system which node 1 just has
> memory but no cpu. This special configuration makes numa system detection
> is_numa(NULL, NH_MEMS, 2) get pass in setup() but test failed in the mem.c
> library funcion test_ksm_merge_across_nodes becuase the NH_CPUS is to requre
> testing node should have cpu.
>
> However, I have gone though all of our LTP ksm tests and confirmed that there
> is no necessary to do cpu check for it, actully only ksm06 invoke that
> funcion.
> In this patch I just remove the NH_CPUS flag to get ksm06 test pass.
>
> # numactl -H
> available: 2 nodes (0-1)
> node 0 cpus: 0 1 2 3 4 5 6 7
> node 0 size: 31431 MB
> node 0 free: 26355 MB
> node 1 cpus:
> node 1 size: 255 MB
> node 1 free: 213 MB
> node distances:
> node 0 1
> 0: 10 40
> 1: 40 10
>
> # ./ksm06
> tst_test.c:1085: INFO: Timeout per run is 0h 10m 00s
> mem.c:539: INFO: need NUMA system support
> tst_test.c:920: BROK: Test haven't reported results!
>
> Signed-off-by: Li Wang < liwang@redhat.com >
Pushed.
Thanks,
Jan
prev parent reply other threads:[~2019-03-20 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 7:11 [LTP] [PATCH] mem/lib: remove NH_CPUS flag from get_allowed_nodes_arr Li Wang
2019-03-20 9:17 ` Li Wang
2019-03-20 12:11 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023246752.10528425.1553083879724.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox