From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49458C3DA6E for ; Wed, 3 Jan 2024 11:25:56 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D83803CE77A for ; Wed, 3 Jan 2024 12:25:53 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id B173E3CB297 for ; Wed, 3 Jan 2024 12:25:38 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 7BCCB600F4C for ; Wed, 3 Jan 2024 12:25:37 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AC68D21180 for ; Wed, 3 Jan 2024 11:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704281136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iFwDktI/r1xVWzOtfEKoZuWYjvfBhgPSF7Gzxd33bME=; b=K6+ScwMyz/QuIfPALKPMNCek3NHvnWLIdkIG134iV4WjYoBlMSRmpTbA1dH8uouGXqv4aj ZOTrX3hDL4WtcdJKdwl3jrP2ZJdDW2khB3z34c60r0KOUoX59MmYqioBIJJuKs51e3Zg5g wajpcGsosY3M/p9bpY4znOWwjCA6tZ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704281136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iFwDktI/r1xVWzOtfEKoZuWYjvfBhgPSF7Gzxd33bME=; b=ZjQgJ21N3Srob2dyGsWPbo5pALREmONObE8hYLJZpctfMPLb/nTlT3w5gH1SCicNRXHwsS QnKwZpMBBD7C8IAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704281136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iFwDktI/r1xVWzOtfEKoZuWYjvfBhgPSF7Gzxd33bME=; b=K6+ScwMyz/QuIfPALKPMNCek3NHvnWLIdkIG134iV4WjYoBlMSRmpTbA1dH8uouGXqv4aj ZOTrX3hDL4WtcdJKdwl3jrP2ZJdDW2khB3z34c60r0KOUoX59MmYqioBIJJuKs51e3Zg5g wajpcGsosY3M/p9bpY4znOWwjCA6tZ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704281136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iFwDktI/r1xVWzOtfEKoZuWYjvfBhgPSF7Gzxd33bME=; b=ZjQgJ21N3Srob2dyGsWPbo5pALREmONObE8hYLJZpctfMPLb/nTlT3w5gH1SCicNRXHwsS QnKwZpMBBD7C8IAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0AAB13AA6 for ; Wed, 3 Jan 2024 11:25:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id sdgzJzBElWWKEQAAD6G6ig (envelope-from ) for ; Wed, 03 Jan 2024 11:25:36 +0000 From: Avinesh Kumar To: ltp@lists.linux.it Date: Wed, 3 Jan 2024 12:25:35 +0100 Message-ID: <20240103112536.1925-1-akumar@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240103112023.32355-1-akumar@suse.de> References: <20240103112023.32355-1-akumar@suse.de> MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=K6+ScwMy; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZjQgJ21N X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.01 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; R_MISSING_CHARSET(2.50)[]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Rspamd-Queue-Id: AC68D21180 X-Virus-Scanned: clamav-milter 1.0.3 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v2] lib: Improve doc X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Signed-off-by: Avinesh Kumar --- lib/README.md | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/lib/README.md b/lib/README.md index ccb1cf1da..dd79e70f4 100644 --- a/lib/README.md +++ b/lib/README.md @@ -27,16 +27,16 @@ When a test is executed the very first thing to happen is that we check for various test prerequisites. These are described in the tst\_test structure and -range from simple '.require\_root' to a more complicated kernel .config boolean +range from simple '.needs\_root' to a more complicated kernel .config boolean expressions such as: "CONFIG\_X86\_INTEL\_UMIP=y | CONFIG\_X86\_UMIP=y". -If all checks are passed the process carries on with setting up the test +If all checks are passed, the process continues with setting up the test environment as requested in the tst\_test structure. There are many different setup steps that have been put into the test library again ranging from rather simple creation of a unique test temporary directory to a bit more complicated ones such as preparing, formatting, and mounting a block device. -The test library also intializes shrared memory used for IPC at this step. +The test library also initializes shared memory used for IPC at this step. Once all the prerequisites are checked and test environment has been prepared we can move on executing the testcase itself. The actual test is executed in a @@ -62,12 +62,11 @@ for test_variants: fork_testrun() ``` -Before we fork() the test process the test library sets up a timeout alarm and -also a heartbeat signal handlers and also sets up an alarm(2) accordingly to -the test timeout. When a test times out the test library gets SIGALRM and the -alarm handler mercilessly kills all forked children by sending SIGKILL to the -whole process group. The heartbeat handler is used by the test process to reset -this timer for example when the test functions run in a loop. +Before we fork() the test process, the test library sets up a timeout alarm and +also a heartbeat signal handler. When a test times out, the test library gets +SIGALRM and the alarm handler mercilessly kills all forked children by sending +SIGKILL to the whole process group. The heartbeat handler is used by the test +process to reset this timer for example when the test functions run in a loop. With that done we finally fork() the test process. The test process firstly resets signal handlers and sets its pid to be a process group leader so that we @@ -97,14 +96,14 @@ usually better option than exiting it in the middle. The test cleanup() is also called by the tst\_brk() handler in order to cleanup before exiting the test process, hence it must be able to cope even with partial test setup. Usually it suffices to make sure to clean up only -resources that already have been set up and to do that in an inverse order that -we did in setup(). +resources that already have been set up and to do that in the reverse order +that we did in setup(). Once the test process exits or leaves the run() or run\_all() function the test library wakes up from the waitpid() call, and checks if the test process exited normally. -Once the testrun is finished the test library does a cleanup() as well to clean +Once the testrun is finished, the test library does a cleanup() as well to clean up resources set up in the test library setup(), reports test results and finally exits the process. @@ -126,8 +125,8 @@ This especially means that: - While the test results are, by the design, propagated to the test library we may still miss a child that gets killed by a signal or exits unexpectedly. -The test writer should, because of this, take care for reaping these proceses -properly, in most cases this could be simply done by calling +The test writer should, because of this, take care of reaping these +processes properly, in most cases this could be simply done by calling tst\_reap\_children() to collect and dissect deceased. Also note that tst\_brk() does exit only the current process, so if a child @@ -136,9 +135,9 @@ exits. ### Test library and exec() -The piece of mapped memory to store the results to is not preserved over +The piece of mapped memory to store the results is not preserved over exec(2), hence to use the test library from a binary started by an exec() it -has to be remaped. In this case the process must to call tst\_reinit() before +has to be remapped. In this case, the process must call tst\_reinit() before calling any other library functions. In order to make this happen the program environment carries LTP\_IPC\_PATH variable with a path to the backing file on tmpfs. This also allows us to use the test library from shell testcases. @@ -148,5 +147,5 @@ tmpfs. This also allows us to use the test library from shell testcases. The piece of mapped memory is also used as a base for a futex-based synchronization primitives called checkpoints. And as said previously the memory can be mapped to any process by calling the tst\_reinit() function. As a -matter of a fact there is even a tst\_checkpoint binary that allows us to use +matter of a fact, there is even a tst\_checkpoint binary that allows us to use the checkpoints from shell code as well. -- 2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp