From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 09/10] lib: Add support for TDEBUG tst_res() flag
Date: Thu, 4 Jan 2024 12:36:42 +0100 [thread overview]
Message-ID: <20240104113642.GA1149671@pevik> (raw)
In-Reply-To: <20231214151954.840244-10-pvorel@suse.cz>
Hi all,
> To print more verbose info. By default it's off, printing enabled with
> -D option or TST_ENABLE_DEBUG=1.
...
> diff --git a/doc/C-Test-API.asciidoc b/doc/C-Test-API.asciidoc
...
> +| 'TINFO' | General message.
> +| 'TDEBUG' | Debug message (new C API only, printed with '-D' or via 'TST_ENABLE_DEBUG=1' or 'y'
> + environment variable), only for messages which would be too verbose for normal run.
...
> +++ b/doc/User-Guidelines.asciidoc
> @@ -41,6 +41,7 @@ For running LTP network tests see `testcases/network/README.md`.
> and others, which imply it, shell: 'TST_NEEDS_TMPDIR=1').
> Must be an absolute path (default: '/tmp').
> | 'TST_NO_CLEANUP' | Disable running test cleanup (defined in 'TST_CLEANUP').
> +| 'TST_ENABLE_DEBUG' | Enable debug info (value 'y' or '1').
This has been merged. But I now wonder, if this would be better with LTP_
prefix, e.g. LTP_ENABLE_DEBUG, because it's a variable which is defined by LTP
user. WDYT?
This might be also case for TST_NO_CLEANUP, but it's rarely used, thus my
concern is more about LTP_ENABLE_DEBUG.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-04 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 15:19 [LTP] [PATCH v4 00/10] Add TDEBUG tst_res() flag Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 01/10] lib/tests: Add test for testing tst_res() flags Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 02/10] tst_test.sh/tst_brk(): Convert only TBROK to TWARN in cleanup Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 03/10] tst_test.sh/tst_brk(): Allow only TBROK and TCONF Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 04/10] ioctl02: Rename option -D => -d Petr Vorel
2023-12-19 11:00 ` Li Wang
2023-12-19 11:42 ` Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 05/10] can_filter: " Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 06/10] can_rcv_own_msgs: " Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 07/10] tst_netload(): Rename option -d => -f Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 08/10] netstress: Rename option -D => -d Petr Vorel
2023-12-14 15:19 ` [LTP] [PATCH v4 09/10] lib: Add support for TDEBUG tst_res() flag Petr Vorel
2024-01-04 11:36 ` Petr Vorel [this message]
2024-01-04 11:55 ` Li Wang
2023-12-14 15:19 ` [LTP] [PATCH v4 10/10] fsx-linux: Reduce log output with TDEBUG Petr Vorel
2023-12-19 10:58 ` [LTP] [PATCH v4 00/10] Add TDEBUG tst_res() flag Li Wang
2023-12-19 12:04 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104113642.GA1149671@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox