Re: [LTP] [PATCH 4/9] metadata: test.sh: Print more info on VERBOSE=1

Cyril Hrubis
2024-02-23T12:54:29Z

Hi!
> diff --git a/metadata/tests/test.sh b/metadata/tests/test.sh
> index 475d721df..a00e32bb4 100755
> --- a/metadata/tests/test.sh
> +++ b/metadata/tests/test.sh
> @@ -3,6 +3,7 @@
> fail=0
>
> for i in *.c; do
> + [ "$VERBOSE" ] && echo "$0: testing $i"

Here as well, just use $V instead, and maybe it does not make sense to
print the $0. Possibly just "parsing $i".

> ../metaparse $i > tmp.json
> if ! diff tmp.json $i.json >/dev/null 2>&1; then
> echo "***"
> @@ -15,4 +16,5 @@ done
>
> rm -f tmp.json
>
> +[ "$VERBOSE" ] && echo "$fail"

Maybe it would make more sense to print pass/fail for each file, i.e.

Parsing array_size01.c Pass
Parsing array_size02.c Pass
Parsing array_size03.c Fail
...

> exit $fail
> --
> 2.43.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp

--
Cyril Hrubis
chrubis@suse.cz