Re: [LTP] [PATCH v1 2/2] execl01.c: set stack to unlimited

Petr Vorel
2023-10-23T11:27:00Z

Hi Wei,

It would be also here mention
https://github.com/linux-test-project/ltp/issues/530

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> testcases/kernel/syscalls/execl/execl01.c | 4 ++++
> 1 file changed, 4 insertions(+)

> diff --git a/testcases/kernel/syscalls/execl/execl01.c b/testcases/kernel/syscalls/execl/execl01.c
> index 9268d4976..5cdd84656 100644
> --- a/testcases/kernel/syscalls/execl/execl01.c
> +++ b/testcases/kernel/syscalls/execl/execl01.c
> @@ -35,4 +35,8 @@ static struct tst_test test = {
> .forks_child = 1,
> .child_needs_reinit = 1,
> .test_all = verify_execl,

BTW #530 mentions execve(). Is it ok that we use it on execl()?

The difference is not big (all glibc wrappers use SYS_execve syscall
internally), so that it might be OK, but how about also add it to some test
which uses execve() + SAFE_FORK()/.fork_child (e.g. execve01.c).

Kind regards,
Petr

> + .ulimit = (const struct tst_ulimit_val[]) {
> + {RLIMIT_STACK, {RLIM_INFINITY, RLIM_INFINITY}},
> + {}
> + },
> };