From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AF1DC4707B for ; Thu, 11 Jan 2024 10:10:17 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id C03163CE434 for ; Thu, 11 Jan 2024 11:10:15 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C2B803C2674 for ; Thu, 11 Jan 2024 11:09:59 +0100 (CET) Authentication-Results: in-5.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 63BD260078E for ; Thu, 11 Jan 2024 11:09:58 +0100 (CET) Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8DBA21F37C; Thu, 11 Jan 2024 10:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704967783; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0GYQm7iGlkYD1bBFktPvKbkpI7AmJLoTq1T9tN9mJ9c=; b=SR8ylwj7nOtgWmuZRKsFxmF8/iJZvlmhgCswSla93Xxhk+qeveJuiTcCzCBS8dO5FMI3Up XvpUWVFvLuO9jZCfoJq2kIbgFuWuuxMcQkRS8izJouDuWiDrrZ19i28m+QLzkFIndWUw2r qLAKqE7+m4j3gPHSV+xx0q47QUsYLf4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704967783; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0GYQm7iGlkYD1bBFktPvKbkpI7AmJLoTq1T9tN9mJ9c=; b=WnReKxWoR5iKlNO104m1Flc7NrFT3JcZgNRyo5BM8G9W+PHROoekbnmf5QYRHuIN5ocb0x szVRKKwax/ZdpCBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704967781; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0GYQm7iGlkYD1bBFktPvKbkpI7AmJLoTq1T9tN9mJ9c=; b=Yf9NAGK0DQ8MKZkyAAC1nkRTmHAC7CtVlyiJn1/lGDLHeF9DGxjxPBP3knrZo+N+S8hr2Q anUTXY6y84l392gKH7jVzy5ESf4H4Lyo8YaHSXTmg7+jJgyuNuIYTE8obkfd+I7FkJLfay l6E/IgHDAmATYtd6zse7kcWXu1anfqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704967781; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0GYQm7iGlkYD1bBFktPvKbkpI7AmJLoTq1T9tN9mJ9c=; b=t2VFQZKtZrNoH8ti0WnQMJVegTILnykWSY/Ulxdj4I+IpDVL4wODPQwuvLp0u6OgwZ64Hq AUIlLGAjimhOb2Bg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 35D00138E5; Thu, 11 Jan 2024 10:08:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id YoMICxi+n2XFNgAAn2gu4w (envelope-from ); Thu, 11 Jan 2024 10:08:24 +0000 Date: Thu, 11 Jan 2024 11:09:49 +0100 From: Petr Vorel To: Pengfei Xu Message-ID: <20240111100949.GA1895489@pevik> References: <48efcb1293a682182fc5db23f01be7af2889e26c.1704949719.git.pengfei.xu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <48efcb1293a682182fc5db23f01be7af2889e26c.1704949719.git.pengfei.xu@intel.com> X-Spamd-Bar: / Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Yf9NAGK0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t2VFQZKt X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-0.69 / 50.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,ozlabs.org:url,suse.cz:dkim]; NEURAL_HAM_SHORT(-0.18)[-0.918]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[36.46%] X-Rspamd-Queue-Id: 8DBA21F37C X-Virus-Scanned: clamav-milter 1.0.3 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1 1/1] keyctl05: improve the dns_res_payload for boundary testing X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Heng Su , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Xu, > Because the following patch will fix the add_key syscall incoming data boundary > size issue, 6 bytes incoming data should pass: > https://lore.kernel.org/all/1784441.1704907412@warthog.procyon.org.uk/ > -> https://lore.kernel.org/all/1850031.1704921100@warthog.procyon.org.uk/ > In order to test above boundary incoming data size, change the dns_res_payload > size. I'm sorry, I was faster and just fixed \ myself. Rebasing is trivial, but there was missing commit (already merged and other things). Thus I have sent v2 under your name (which I actually forget to mark as v2 :(). https://lore.kernel.org/ltp/20240111100636.1897637-1-pvorel@suse.cz/ https://patchwork.ozlabs.org/project/ltp/patch/20240111100636.1897637-1-pvorel@suse.cz/ Can you please have a look on it? Kind regards, Petr > Signed-off-by: Pengfei Xu > --- > testcases/kernel/syscalls/keyctl/keyctl05.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > diff --git a/testcases/kernel/syscalls/keyctl/keyctl05.c b/testcases/kernel/syscalls/keyctl/keyctl05.c > index 90cf1ef06..50e78853c 100644 > --- a/testcases/kernel/syscalls/keyctl/keyctl05.c > +++ b/testcases/kernel/syscalls/keyctl/keyctl05.c > @@ -199,11 +199,11 @@ static void do_test(unsigned int i) > * We need to pass check in dns_resolver_preparse(), > * give it dummy server list request. > * From v6.7-rc8 commit 1997b3cb4217b09e49659b634c94da47f0340409: > - * the incoming data for add_key syscall should be larger than 6 bytes, > - * because struct dns_server_list_v1_header without body is 6 bytes. > + * the incoming data for add_key syscall should be not less than 6 > + * bytes, because struct dns_server_list_v1_header is 6 bytes. > + * The minimum payload will be tested here for boundary testing. > */ > - static char dns_res_payload[] = { 0x00, 0x00, 0x01, 0xff, 0x00, \ > - 0x00, 0x00 }; > + static char dns_res_payload[] = { 0x00, 0x00, 0x01, 0xff, 0x00, 0x00 }; > switch (i) { > case 0: -- Mailing list info: https://lists.linux.it/listinfo/ltp