From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Cc: jhs@mojatatu.com
Subject: [LTP] [PATCH] tcindex01: fix compilation errors due to missing TCA_TCINDEX_ constants
Date: Tue, 16 Jan 2024 11:17:28 +0800 [thread overview]
Message-ID: <20240116031728.2500892-1-liwang@redhat.com> (raw)
The change addresses compilation errors encountered in the tcindex01.c
test when compiled against kernel-6.7 and above.
tcindex01.c:67:4: error: ‘TCA_TCINDEX_MASK’ undeclared here (not in a function);
did you mean ‘TCA_CODEL_MAX’?
{TCA_TCINDEX_MASK, &mask, sizeof(mask), NULL},
^~~~~~~~~~~~~~~~
TCA_CODEL_MAX
tcindex01.c:68:4: error: ‘TCA_TCINDEX_SHIFT’ undeclared here (not in a function);
did you mean ‘TCA_FLOW_RSHIFT’?
{TCA_TCINDEX_SHIFT, &shift, sizeof(shift), NULL},
^~~~~~~~~~~~~~~~~
TCA_FLOW_RSHIFT
CC testcases/cve/cve-2016-7117
CC utils/sctp/func_tests/test_getname_v6.o
tcindex01.c:69:4: error: ‘TCA_TCINDEX_CLASSID’ undeclared here (not in a function);
did you mean ‘TCA_FLOWER_CLASSID’?
{TCA_TCINDEX_CLASSID, &clsid, sizeof(clsid), NULL},
^~~~~~~~~~~~~~~~~~~
TCA_FLOWER_CLASSID
The errors were due to the removal of certain TCA_TCINDEX_ constants
from the kernel's user API (uapi), as indicated by the kernel commit.
commit 82b2545ed9a (net/sched: Remove uapi support for tcindex classifier)
The reason why I didn't add this into LTP library is that the defines
have been dropped we just need to satisfy this one case.
---
Notes:
We need to merge this patch before the new release.
testcases/cve/tcindex01.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/testcases/cve/tcindex01.c b/testcases/cve/tcindex01.c
index b4f2bb01a..70e5639f1 100644
--- a/testcases/cve/tcindex01.c
+++ b/testcases/cve/tcindex01.c
@@ -32,6 +32,23 @@
#define DEVNAME "ltp_dummy1"
+#ifndef TCA_TCINDEX_MAX
+enum {
+ TCA_TCINDEX_UNSPEC,
+ TCA_TCINDEX_HASH,
+ TCA_TCINDEX_MASK,
+ TCA_TCINDEX_SHIFT,
+ TCA_TCINDEX_FALL_THROUGH,
+ TCA_TCINDEX_CLASSID,
+ TCA_TCINDEX_POLICE,
+ TCA_TCINDEX_ACT,
+ __TCA_TCINDEX_MAX
+};
+
+#define TCA_TCINDEX_MAX (__TCA_TCINDEX_MAX - 1)
+#endif
+
+
static const uint32_t qd_handle = TC_H_MAKE(1 << 16, 0);
static const uint32_t clsid = TC_H_MAKE(1 << 16, 1);
static const uint32_t shift = 10;
--
2.40.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2024-01-16 3:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 3:17 Li Wang [this message]
2024-01-16 12:12 ` [LTP] [PATCH] tcindex01: fix compilation errors due to missing TCA_TCINDEX_ constants Petr Vorel
2024-01-17 1:42 ` Li Wang
2024-01-17 9:08 ` Petr Vorel
2024-01-16 12:38 ` Martin Doucha
2024-01-16 16:10 ` Petr Vorel
2024-01-17 15:52 ` Jamal Hadi Salim
2024-01-18 0:48 ` Li Wang
2024-01-21 17:24 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116031728.2500892-1-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=jhs@mojatatu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox