public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] keyctl05: Add modprobe dns_resolver
Date: Thu, 18 Jan 2024 14:38:46 +0100	[thread overview]
Message-ID: <20240118133846.GA2774347@pevik> (raw)
In-Reply-To: <ZakWJ0ZqrLWTQFty@yuki>

Hi Cyril, all,

> Hi!
> > This avoids TCONF when module not loaded:
> > keyctl05.c:99: TCONF: kernel doesn't support key type 'dns_resolver'

> > There is no way to trigger module loading automatically.

> I just checked the kernel add_key() syscall and indeed there is no way
> the sycall would load a module, all it does is to loop over already
> registered kernel key types.

Thanks for checking this!

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Hi,

> > a candidate to merge before release (simple enough).

> > I'll try to send a patchset for .modprobe_module before the release, but
> > I suppose we should merge it after the release anyway. That's why I
> > added this simple patch. And therefore I don't bother with 'modprobe -r',
> > neither with requiring modprobe (will be in .modprobe_module).

> Sounds like a plan. Let's go for this workaround before the release
> then.

+1

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Thanks, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-01-18 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11  9:45 [LTP] [PATCH 1/1] keyctl05: Add modprobe dns_resolver Petr Vorel
2024-01-18 12:14 ` Cyril Hrubis
2024-01-18 13:38   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240118133846.GA2774347@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox