public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] runtest/net.nfs: Rename test names
Date: Sun, 21 Jan 2024 20:37:56 +0100	[thread overview]
Message-ID: <20240121193756.GB51882@pevik> (raw)
In-Reply-To: <ZaqjLqW1PAUUNMwE@yuki>

> Hi!
> > -nfs01_06  nfs06.sh -v "3,3,3,4,4,4" -t "udp,udp,tcp,tcp,tcp,tcp"
> > -nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> > -nfs03_ipv6_06 nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> > +nfs06.sh_v3_v4_ipv4_tcp_udp  nfs06.sh -v "3,3,3,4,4,4" -t "udp,udp,tcp,tcp,tcp,tcp"
> > +nfs06.sh_vall_ipv4tcp nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> > +nfs06.sh_v4*_ipv6_tcp nfs03_ipv6_06 nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"

> Putting * into a test name is asking for a trouble, who knows where it
> may expand...

Hi Cyril,

would be nfs06.sh_v4+_ipv6_tcp better? or nfs06.sh_v4plus_ipv6_tcp
Or should I merge as nfs06.sh_v4_ipv6_tcp

Thanks a lot for having a look!

Kind regards,
Petr

> Otherwise I'm all for having more descriptive names:

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-01-21 19:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 16:09 [LTP] [PATCH 1/2] tst_test.sh: Print test command + params Petr Vorel
2023-10-31 16:09 ` [LTP] [PATCH 2/2] runtest/net.nfs: Rename test names Petr Vorel
2024-01-19 16:28   ` Cyril Hrubis
2024-01-21 19:37     ` Petr Vorel [this message]
2024-01-30 12:29   ` Martin Doucha
2024-01-30 13:19     ` Petr Vorel
2024-01-19 16:31 ` [LTP] [PATCH 1/2] tst_test.sh: Print test command + params Cyril Hrubis
2024-01-21 19:59   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240121193756.GB51882@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox